-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DISCO_F413ZH: Add new platform #4410
Conversation
@arostm Can you look at the travis CI failure? https://travis-ci.org/ARMmbed/mbed-os/builds/238354943#L1405 |
I think it is due to the line 234 in build_travis.py (rtos) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has this been tested (updated to the latest master - rtx2 ) ?
tools/build_travis.py
Outdated
{"target": "DISCO_F413ZH", | ||
"toolchains": "GCC_ARM", | ||
"tests": {"" : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"], | ||
"rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove rtos from here
There are conflicts, please resolve. |
Hello, I did a rebase |
tools/build_travis.py
Outdated
{ "target": "DISCO_F407VG", "toolchains": "GCC_ARM", "libs": ["dsp", "usb"] }, | ||
{ "target": "DISCO_F413ZH", "toolchians": "GCC_ARM", "libs": ["dsp", "usb"]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typo is breaking travis CI:
toolchians => toolchains
@arostm Could you fix the aforementioned typo? |
Hello, I did the modification in build_travis.py. Sorry for the mistake |
After a rebase, all the tests are ok, can you approve and merge it ? |
Thanks ! We will review the latest rebase and run CI afterwards. |
@arostm Sorry there was another merge that caused conflicts here for the previous release. we would like to proceed with this one, can you please rebase? |
- leds definition - add sw4stm32 exporter - recomment mco debug
Needed to pass ci-test-shield tests.
The board have to use th hal_conf file from F4/device directory
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
LGTM |
Description
This PR add this new board
Status
READY
##Test Report
F413ZH.zip
Migrations
NO
CC @bcostm @adustm @jeromecoutant @LMESTM