Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_F413ZH: Add new platform #4410

Merged
merged 20 commits into from
Jun 23, 2017
Merged

Conversation

arostm
Copy link
Contributor

@arostm arostm commented May 31, 2017

Description

This PR add this new board

Status

READY

##Test Report
F413ZH.zip

Migrations

NO

CC @bcostm @adustm @jeromecoutant @LMESTM

@sg-
Copy link
Contributor

sg- commented Jun 3, 2017

@arostm Can you look at the travis CI failure? https://travis-ci.org/ARMmbed/mbed-os/builds/238354943#L1405

@bcostm
Copy link
Contributor

bcostm commented Jun 5, 2017

I think it is due to the line 234 in build_travis.py (rtos)

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been tested (updated to the latest master - rtx2 ) ?

{"target": "DISCO_F413ZH",
"toolchains": "GCC_ARM",
"tests": {"" : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
"rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove rtos from here

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2017

There are conflicts, please resolve.

@arostm
Copy link
Contributor Author

arostm commented Jun 12, 2017

Hello, I did a rebase

{ "target": "DISCO_F407VG", "toolchains": "GCC_ARM", "libs": ["dsp", "usb"] },
{ "target": "DISCO_F413ZH", "toolchians": "GCC_ARM", "libs": ["dsp", "usb"]},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo is breaking travis CI:
toolchians => toolchains

@theotherjimmy
Copy link
Contributor

@arostm Could you fix the aforementioned typo?

@arostm
Copy link
Contributor Author

arostm commented Jun 13, 2017

Hello, I did the modification in build_travis.py. Sorry for the mistake

@arostm
Copy link
Contributor Author

arostm commented Jun 15, 2017

After a rebase, all the tests are ok, can you approve and merge it ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2017

After a rebase, all the tests are ok, can you approve and merge it ?

Thanks ! We will review the latest rebase and run CI afterwards.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2017

@arostm Sorry there was another merge that caused conflicts here for the previous release. we would like to proceed with this one, can you please rebase?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 612

All builds and test passed!

@adbridge
Copy link
Contributor

LGTM

@adbridge adbridge merged commit f1d0314 into ARMmbed:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants