Flash api nRF52840 #4282

kl-cruz · 2017-05-08T07:25:49Z

Notes:
Adding support for flashiap for nRF52840 devices. This is second pull request. This one was started from master branch (I did cherry pick of few commits). Tests were passed but... There is a nasty bug on master now: #4237 . It is necessary to remove first line in hex files and run tests with switch --run:

compile:
mbed test -n "tests-mbed_drivers-flashiap" -t GCC_ARM -m NRF52840_dk -c
Remove first line in hex files
Rerun tests without compilation:
mbed test -n "tests-mbed_drivers-flashiap" -t GCC_ARM -m NRF52840_dk --run
Run these three steps for "tests-mbed_hal-flash" tests

Status

READY

Related Issues

#4237

0xc0170 · 2017-05-08T10:08:41Z

LGTM

3 small things that can help:

not using [] in the first line in the commit, as git takes that as email header and with some commands (usually associated with emails) strip that
use commit msg powers to explain how it fixes an issue ([nRF52840] Fixed flashapi test and casting issue commit fixes the flashapi - why is it removing that header - is it unnecessary, compile error with some conditions, etc)
if there are tests, paste here results

kl-cruz · 2017-05-08T11:11:07Z

first dot: Ok, I'll remember.

second: this header is included in flash_api.h with proper preprocesor if

third:

C:\Repositories\mbed-os>mbed test -n "tests-mbed_hal-flash" -t GCC_ARM -m NRF52840_dk --run
mbedgt: greentea test automation tool ver. 1.2.5
mbedgt: test specification file 'C:\Repositories\mbed-os\BUILD\tests\NRF52840_dk\GCC_ARM\test_spec.
json' (specified with --test-spec option)
mbedgt: using 'C:\Repositories\mbed-os\BUILD\tests\NRF52840_dk\GCC_ARM\test_spec.json' from current
 directory!
mbedgt: detecting connected mbed-enabled devices...
mbedgt: detected 1 device
mbedgt: processing target 'NRF52840_DK' toolchain 'GCC_ARM' compatible platforms... (note: switch set to --parallel 1)
mbedgt: test case filter (specified with -n option)
        test filtered in 'tests-mbed_hal-flash'
mbedgt: running 1 test for platform 'NRF52840_DK' and toolchain 'GCC_ARM'
mbedgt: mbed-host-test-runner: started
mbedgt: checking for GCOV data...
mbedgt: test on hardware with target id: 1102022144203120414A4E393130323133323034B9FEDFDA
mbedgt: test suite 'tests-mbed_hal-flash' ............................................................ OK in 18.19 sec
        test case: 'Flash - buffer alignment test' ................................................... OK in 0.56 sec
        test case: 'Flash - clock and cache test' .................................................... OK in 0.16 sec
        test case: 'Flash - erase sector' ............................................................ OK in 0.13 sec
        test case: 'Flash - init' .................................................................... OK in 0.15 sec
        test case: 'Flash - mapping alignment' ....................................................... OK in 0.05 sec
        test case: 'Flash - program page' ............................................................ OK in 0.31 sec
mbedgt: test case summary: 6 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.7887740288
mbedgt: test suite report:
+---------------------+---------------+----------------------+--------+--------------------+-------------+
| target              | platform_name | test suite           | result | elapsed_time (sec) | copy_method |
+---------------------+---------------+----------------------+--------+--------------------+-------------+
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | OK     | 18.19              | shell       |
+---------------------+---------------+----------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 OK
mbedgt: test case report:
+---------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
| target              | platform_name | test suite           | test case                     | passed | failed | result | elapsed_time (sec) |
+---------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | Flash - buffer alignment test | 1      | 0      | OK     | 0.56               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | Flash - clock and cache test  | 1      | 0      | OK     | 0.16               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | Flash - erase sector          | 1      | 0      | OK     | 0.13               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | Flash - init                  | 1      | 0      | OK     | 0.15               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | Flash - mapping alignment     | 1      | 0      | OK     | 0.05               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_hal-flash | Flash - program page          | 1      | 0      | OK     | 0.31               |
+---------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 6 OK
mbedgt: completed in 23.15 sec

C:\Repositories\mbed-os>mbed test -n "tests-mbed_drivers-flashiap" -t GCC_ARM -m NRF52840_dk --run
[mbed] WARNING: Could not find mbed program in current path "C:\Repositories\mbed-os".
[mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
---
mbedgt: greentea test automation tool ver. 1.2.5
mbedgt: test specification file 'C:\Repositories\mbed-os-example-qspi\mbed-os\BUILD\tests\NRF52840_dk\GCC_ARM\test_spec.
json' (specified with --test-spec option)
mbedgt: using 'C:\Repositories\mbed-os\BUILD\tests\NRF52840_dk\GCC_ARM\test_spec.json' from current
 directory!
mbedgt: detecting connected mbed-enabled devices...
mbedgt: detected 1 device
mbedgt: processing target 'NRF52840_DK' toolchain 'GCC_ARM' compatible platforms... (note: switch set to --parallel 1)
mbedgt: test case filter (specified with -n option)
        test filtered in 'tests-mbed_drivers-flashiap'
mbedgt: running 1 test for platform 'NRF52840_DK' and toolchain 'GCC_ARM'
mbedgt: mbed-host-test-runner: started
mbedgt: checking for GCOV data...
mbedgt: test on hardware with target id: 1102022144203120414A4E393130323133323034B9FEDFDA
mbedgt: test suite 'tests-mbed_drivers-flashiap' ..................................................... OK in 16.54 sec
        test case: 'FlashIAP - init' ................................................................. OK in 0.05 sec
        test case: 'FlashIAP - program' .............................................................. OK in 0.18 sec
        test case: 'FlashIAP - program errors' ....................................................... OK in 0.05 sec
mbedgt: test case summary: 3 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.1185576987
mbedgt: test suite report:
+---------------------+---------------+-----------------------------+--------+--------------------+-------------+
| target              | platform_name | test suite                  | result | elapsed_time (sec) | copy_method |
+---------------------+---------------+-----------------------------+--------+--------------------+-------------+
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_drivers-flashiap | OK     | 16.54              | shell       |
+---------------------+---------------+-----------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 OK
mbedgt: test case report:
+---------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| target              | platform_name | test suite                  | test case                 | passed | failed | result | elapsed_time (sec) |
+---------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_drivers-flashiap | FlashIAP - init           | 1      | 0      | OK     | 0.05               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_drivers-flashiap | FlashIAP - program        | 1      | 0      | OK     | 0.18               |
| NRF52840_DK-GCC_ARM | NRF52840_DK   | tests-mbed_drivers-flashiap | FlashIAP - program errors | 1      | 0      | OK     | 0.05               |
+---------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 3 OK
mbedgt: completed in 20.64 sec

0xc0170 · 2017-05-08T13:37:40Z

@kl-cruz As these are few commits, and we shall start fixing these commit messages, c an you rebase this to remove [] ? Should be fairly quick?

From [nRF52840] Fixed flashapi test and casting issue to nRF52840: Fixed flashapi test and casting issue.

AnotherButler · 2017-05-08T16:50:44Z

@kl-cruz Because we're on the subject of commit messages, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. I find commit.template to be particularly useful. Thanks for your contributions.

@0xc0170 How much does [] affect things? In our release notes, I've been changing : to [] to get rid of the awkward double colon, but if we're recommending that everyone use colons, I may have to consider changing that.

0xc0170 · 2017-05-11T09:33:56Z

@0xc0170 How much does [] affect things? In our release notes, I've been changing : to [] to get rid of the awkward double colon, but if we're recommending that everyone use colons, I may have to consider changing that.

We will have to check to use a flag to overcome this removing [] from the commit line for git am. However, we agreed to use Subject: format, and you can find it in the git history, it will be captured in the docs soon (the docs we did was back then private and was not pushed to public repo, will be fixed).

0xc0170 · 2017-05-11T09:38:21Z

@kl-cruz It should be good to go. If you got time to improve the commit msg, let us know.

0xc0170 · 2017-05-15T15:12:59Z

Can you please rebase ? The refactor of nrf51 SDK (to include 52) was merged prior this one.

pan- · 2017-05-16T10:00:27Z

@kl-cruz What would it requires to use the flash API while the softdevice is enabled ? Wouldn't it be possible to take advantage of sd_flash_page_erase and sd_flash_write, both of those call can be use whether the softdevice is enabled or inactive.

kl-cruz · 2017-05-16T13:19:58Z

I aligned this branch to master (prior to: #4245). Tests passed.

@pan- We can consider to use sd* related functions in next iteration

nvlsianpu · 2017-05-16T13:54:37Z

@pan- We don't have enough time to implement such a solution now (we are overwhelmed). As a compromise we want contribute the BLE-off solution - this still make e.g. flashing from SD card possible. As @kl-cruz mention we can enhance this latter.

theotherjimmy · 2017-05-16T14:08:57Z

@kl-cruz It looks like you merged. Could you rebase instead?

kl-cruz · 2017-05-17T07:28:51Z

Rebased and changed brackets

0xc0170 · 2017-05-17T09:15:46Z

/morph test

0xc0170 · 2017-05-17T09:20:24Z

@pan- Happy with this patch (the answers above provided) ?

pan- · 2017-05-17T09:46:39Z

@0xc0170 lgtm

mbed-bot · 2017-05-17T11:14:16Z

Result: NOT_BUILT

Your command has finished executing! Here's what you wrote!

/morph test

0xc0170 · 2017-05-18T10:05:00Z

/morph test

studavekar · 2017-05-21T06:27:38Z

Re-triggering

/morph test

mbed-bot · 2017-05-21T07:41:40Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 290

All builds and test passed!

kl-cruz mentioned this pull request May 8, 2017

Mbed os workshop 17q2 nordic flash api #4234

Closed

kl-cruz force-pushed the FlashAPI_nRF52840 branch from dd7570b to 8540fdf Compare May 8, 2017 09:32

sg- added the needs: review label May 9, 2017

0xc0170 added ready for merge and removed needs: review labels May 11, 2017

0xc0170 added needs: work and removed ready for merge labels May 15, 2017

kl-cruz added 7 commits May 17, 2017 09:20

nRF52840: Added flash_api implementation

39b0ef5

nRF52840: Cleaned up code

5e057a6

nRF52840: Added checking if sd is enabled in flashapi

bd25d3b

nRF52840: Removed unused, commented code

7761af2

nRF52840: Aligned sources to coding standard

98d4a13

nRF52840: Fixed flashapi test and casting issue

4bb818c

nRF52840: Align sources after rebase

5cac624

kl-cruz force-pushed the FlashAPI_nRF52840 branch from 1ed8744 to 5cac624 Compare May 17, 2017 07:27

kl-cruz changed the title ~~Flash api n rf52840~~ Flash api nRF52840 May 17, 2017

0xc0170 added the needs: CI label May 17, 2017

0xc0170 removed the needs: work label May 17, 2017

adbridge added ready for merge and removed needs: CI labels May 22, 2017

sg- merged commit 58e8881 into ARMmbed:master May 26, 2017

sg- added release-version: 5.4.7 and removed ready for merge labels May 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flash api nRF52840 #4282

Flash api nRF52840 #4282

kl-cruz commented May 8, 2017

0xc0170 commented May 8, 2017 •

edited

Loading

kl-cruz commented May 8, 2017

0xc0170 commented May 8, 2017

AnotherButler commented May 8, 2017

0xc0170 commented May 11, 2017

0xc0170 commented May 11, 2017

0xc0170 commented May 15, 2017

pan- commented May 16, 2017 •

edited

Loading

kl-cruz commented May 16, 2017

nvlsianpu commented May 16, 2017

theotherjimmy commented May 16, 2017

kl-cruz commented May 17, 2017

0xc0170 commented May 17, 2017

0xc0170 commented May 17, 2017

pan- commented May 17, 2017

mbed-bot commented May 17, 2017

0xc0170 commented May 18, 2017

studavekar commented May 21, 2017

mbed-bot commented May 21, 2017

Flash api nRF52840 #4282

Flash api nRF52840 #4282

Conversation

kl-cruz commented May 8, 2017

Status

Related Issues

0xc0170 commented May 8, 2017 • edited Loading

kl-cruz commented May 8, 2017

0xc0170 commented May 8, 2017

AnotherButler commented May 8, 2017

0xc0170 commented May 11, 2017

0xc0170 commented May 11, 2017

0xc0170 commented May 15, 2017

pan- commented May 16, 2017 • edited Loading

kl-cruz commented May 16, 2017

nvlsianpu commented May 16, 2017

theotherjimmy commented May 16, 2017

kl-cruz commented May 17, 2017

0xc0170 commented May 17, 2017

0xc0170 commented May 17, 2017

pan- commented May 17, 2017

mbed-bot commented May 17, 2017

Result: NOT_BUILT

0xc0170 commented May 18, 2017

studavekar commented May 21, 2017

mbed-bot commented May 21, 2017

Result: SUCCESS

Output

0xc0170 commented May 8, 2017 •

edited

Loading

pan- commented May 16, 2017 •

edited

Loading