CFSTORE fixes for building with DEBUG trace enabled

[simonqhughes]

Description

This pull request includes minor corrections so that Configuration Store can be built successfully with debug trace enabled. This was prevented by correcting debug statements referencing variables that are out of scope.

Status

READY

Migrations

No API have changed.

Related PRs

There are no related pull requests.

Todos

No further work is required.

Deploy notes

No changes to deployment environment

Steps to test or reproduce

The problem can be reproduced by:

• not including this commit
• in cfstore_debug.h, change line 32: from

#define noCFSTORE_DEBUG

to

#define CFSTORE_DEBUG

then build. The errors will then be reported.

[0xc0170]

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1213

All builds and test passed!

[bridadan]

Probably should run the nightly on this so the cfstore tests run.

/morph test-nightly

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1229

Test failed!

[bridadan]

CFStore tests are all ok, just that darn event test randomly failing on the NCS36510. Here's the log from the failure (@geky):

[1481229975.74][CONN][RXD] >>> Running case #8: 'Testing call_every'...
[1481229975.78][CONN][INF] found KV pair in stream: {{__testcase_start;Testing call_every}}, queued...
[1481229977.24][CONN][RXD] :73::FAIL: Values Not Within Delta 2 Expected 1400 Was 1465
[1481229977.29][CONN][INF] found KV pair in stream: {{__testcase_finish;Testing call_every;0;1}}, queued...
[1481229977.37][CONN][RXD] >>> 'Testing call_every': 0 passed, 1 failed with reason 'Assertion Failed'

Shouldn't block this PR though 👍

[geky]

‏‏‏‏‏ 

[bridadan]

@geky could you be more specific? 😝

[geky]

 

[adbridge]

/morph-test-nightly

[adbridge]

@geky @bridadan PRs going forward have to be all green before they will be merged. If we thus have an intermittent fault in the CI it needs to be investigated and fixed ASAP or it will start to hold up a lot of work...

[bridadan]

Agreed @adbridge, thanks. That wasn't quite the right command, I'll restart it now:

/morph test-nightly

[adbridge]

@bridadan well spotted! argghh that's typos for you!! We should find a way to flag things like that back to the user?

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1269

All builds and test passed!

[bridadan]

Test results look good, thanks for your patience @simonqhughes

[geky]

@adbridge, sorry, the issue is currently being tracked here: #3404