STM32: Refactor us_ticker.c + hal_tick.c files

[bcostm]

Description

The goal of this PR is to refactor the us_ticker.c and hal_tick.c files.

Now only 4 files are used for all the STM32 devices and placed in TARGET_STM folder:

• us_ticker_16b.c + hal_tick_16b.c for devices using a 16bit timer
• us_ticker_32b.c + hal_tick_32b.c for devices using a 32bit timer

Two definitions have also been added in the hal_tick.h file to indicate the timer type and the peripheral clock number:
#define TIM_MST_16BIT 1 // 1=16-bit timer, 0=32-bit timer
#define TIM_MST_PCLK 2 // Select the peripheral clock number (1 or 2)

Status

READY

Migrations

NO

[bridadan]

Man, gotta love that diff! 😄 Thanks for the changes @bcostm!

/morph test

[bridadan]

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1012

Test failed!

[mbed-bot]

[Build 1092]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

[bridadan]

There was a timing failure on an unrelated board. We were experiencing an issue with one of our CI machines this morning, so this is most likely an infrastructure issue. I'll rerun it now.

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1020

All builds and test passed!

[bridadan]

@0xc0170 Could you review please?

[0xc0170]

why did you change the style ? I understand there might be some inconsistency that should be fixed . It was good as it was.

[bcostm]

humm... I thought it was the correct style this is why I changed it. But ok I will modify it.

[0xc0170]

2016?

[bcostm]

ok I will update it

[0xc0170]

Impressive diff for this one. +1 @bcostm . I just left there style comments.

[bcostm]

Rebased + typo corrections. As you can note, I have also updated the license + date. I took the same license as written in mbed.h file.

[0xc0170]

Future reference: Please write more descriptive commit messages, this commit msg could be improved Minor changes

[0xc0170]

/morph test

[0xc0170]

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

[0xc0170]

Our CI needs restarting, once CI done, all good, this should be ready for integration.

cc @bridadan

[bridadan]

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

[bridadan]

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1125

All builds and test passed!

[mbed-bot]

[Build 1125]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

[0xc0170]

@bcostm I see some regression for this PR. I compared this to the latest nightly (master), all is regarding timers, so might be legit

Nucleo L053R8 - IAR - Timeout Int us FAIL
Nucleo F411RE - uARM - Ticker Int and Timeout Int us

// Timeout Int us
BED: Instrumentation: "COM24" and disk: "R:"
HOST: Copy image onto target...
        1 file(s) copied.
Looking for NUCLEO_F411RE with MBEDLS
Remount complete
HOST: Initialize serial port...
Looking for NUCLEO_F411RE with MBEDLS
...port ready!
HOST: Reset target...
HOST: Property 'timeout' = '15'
HOST: Property 'host_test_name' = 'wait_us_auto'
HOST: Property 'description' = 'Timeout Int us'
HOST: Property 'test_id' = 'MBED_24'
HOST: Start test...
* in 1.01 sec (0.01) [OK]
* in 1.01 sec (0.01) [OK]
* in 1.01 sec (0.01) [OK]
* in 1.01 sec (0.01) [OK]
* in 1.01 sec (0.01) [OK]
* in 1.01 sec (0.01) [OK]
* in 0.30 sec (0.70) [FAIL]
* in 1.72 sec (0.72) [FAIL]
* in 1.01 sec (0.01) [OK]
* in 0.22 sec (0.78) [FAIL]
* in 1.80 sec (0.80) [FAIL]
* in 1.01 sec (0.01) [OK]
* in 1.01 sec (0.01) [OK]
Consecutive OK timer reads: 2
Completed in 13.10 sec

{{failure}}
{{end}}

// Ticker Int
	
MBED: Instrumentation: "COM24" and disk: "R:"
HOST: Copy image onto target...
        1 file(s) copied.
Looking for NUCLEO_F411RE with MBEDLS
Remount complete
HOST: Initialize serial port...
Looking for NUCLEO_F411RE with MBEDLS
...port ready!
HOST: Reset target...
HOST: Property 'timeout' = '15'
HOST: Property 'host_test_name' = 'wait_us_auto'
HOST: Property 'description' = 'Ticker Int'
HOST: Property 'test_id' = 'MBED_11'
HOST: Start test...
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 0.51 sec (0.49) [FAIL]
* in 1.48 sec (0.48) [FAIL]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 0.65 sec (0.35) [FAIL]
* in 1.34 sec (0.34) [FAIL]
* in 1.00 sec (0.00) [OK]
* in 0.85 sec (0.15) [FAIL]
* in 1.15 sec (0.15) [FAIL]
Consecutive OK timer reads: 0
Completed in 13.00 sec

{{failure}}

Nucleo F334R8 - uARM - TIme us

//Time us
MBED: Instrumentation: "COM68" and disk: "I:"
HOST: Copy image onto target...
        1 file(s) copied.
Looking for NUCLEO_F334R8 with MBEDLS
Remount complete
HOST: Initialize serial port...
Looking for NUCLEO_F334R8 with MBEDLS
...port ready!
HOST: Reset target...
HOST: Property 'timeout' = '15'
HOST: Property 'host_test_name' = 'wait_us_auto'
HOST: Property 'description' = 'Time us'
HOST: Property 'test_id' = 'MBED_25'
HOST: Start test...
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
* in 0.40 sec (0.60) [FAIL]
* in 1.60 sec (0.60) [FAIL]
* in 1.00 sec (0.00) [OK]
* in 0.35 sec (0.65) [FAIL]
* in 1.65 sec (0.65) [FAIL]
* in 1.00 sec (0.00) [OK]
* in 1.00 sec (0.00) [OK]
Consecutive OK timer reads: 2
Completed in 13.01 sec

{{failure}}

[0xc0170]

Running it one more time to be certain:

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

[mbed-bot]

[Build 1132]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

[bcostm]

What is the result of the last tests ? Do I need to do something ?

[bridadan]

Looks there was failure on the NUCLEO_L053R8. I'm gonna run it one more time just to be sure.

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=NUCLEO_L053R8

[mbed-bot]

[Build 1142]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

[0xc0170]

Tests look OK, not connected to this patch (that failure is random). As stated above, @bcostm are you aware of this, can you reproduce locally ?

This shall be good to go