-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User trim values for NCS36510 #3159
Conversation
Astyle and pylint run on code.
@@ -0,0 +1,8 @@ | |||
{ | |||
"mac-addr-low": "0x12345678", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radhika-raghavendran can you move the config into targets.json? https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1838 |
@sg- Would it be better to retain ncs36510_user_trim.json as is and placed in the same folder as targets.json? |
The config can be placed in targets.json just like https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1839 This will reduce hidden config files |
I had a look at https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L1839. |
Yes, look at Config class, that would return what you need (provides API to get targets data). should be |
@0xc0170 Using this API does not give me the value of the tag. Data params {'target.mac-addr-high': tools.config.ConfigParameter object at 0x000000000369C4A8, 'target.txtune-trim': <tools.config.ConfigParameter object at 0x000000000369C748, 'target.32MHz-clk-trim': <tools.config.ConfigParameter object at 0x000000000369C5F8, 'target.mac-addr-low': <tools.config.ConfigParameter object at 0x000000000369C438, 'target.32KHz-clk-trim': <tools.config.ConfigParameter object at 0x000000000369C550, 'target.rssi-trim': <tools.config.ConfigParameter object at 0x000000000369C6A0} Here is the config params: Any sample usage will be very helpful. Thanks |
@bogdanm Could you please look at the comment above? |
@radhika-raghavendran, once you have a |
@0xc0170 I have made the necessary changes to remove usage of a separate json file in targets and added configuration data for NCS36510 in targets.json file. You can review and let me know if there is a better way to implement the same. A get_value method with the name of the tag for ConfigParameter class would be very useful. |
Hi @radhika-raghavendran, Thanks! |
@maclobdell : Modifications made for MAC address and other trim default values. Comments added in json file. Thanks |
Attached are the latest test results. |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1031 All builds and test passed! |
Ports for Upcoming Targets Fixes and Changes 3127: Fixed the issue about push/pop of VFP register. ARMmbed/mbed-os#3127 3176: Modifying micro:bit pin names to mirror micro:bit edge connector ARMmbed/mbed-os#3176 3160: Fix wrong index at LPC43xx tx end ring assignment ARMmbed/mbed-os#3160 3217: Add I2C_ASYNCH capability for DISCO_F469NI ARMmbed/mbed-os#3217 3211: [NUC472/M453] Support single UART shared by multiple serial objects and other updates ARMmbed/mbed-os#3211 3198: NUCLEO_F410RB: Add I2C_ASYNCH capability ARMmbed/mbed-os#3198 3194: Update K64 sdk drivers ARMmbed/mbed-os#3194 3159: User trim values for NCS36510 ARMmbed/mbed-os#3159 3243: Fix make exporters compilation ARMmbed/mbed-os#3243 3231: STM32F3: DISCO_F303VC - Add missing UART and ADC pin muxing options ARMmbed/mbed-os#3231 3233: K20xx Calculate PWM clock relative to bus clock ARMmbed/mbed-os#3233 3237: Added back USART 6 pins ARMmbed/mbed-os#3237 3253: Fix default polarity on LPC43XX PWM driver ARMmbed/mbed-os#3253 3238: Dev i2c stm32f4hal ARMmbed/mbed-os#3238 3251: Dev stm32l0 cube v1.7.0 ARMmbed/mbed-os#3251 3252: [NORDIC - NRF51 - MBED 2] Fix non handled RTC IRQ ARMmbed/mbed-os#3252
Adding user trim programming for NCS36510. Attached is the test result.
GCC_ARM_TestResults-28-10-2016.txt