Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN allow to adapt antenna gain #15471

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Nov 30, 2023

Summary of changes

Allow to override default antenna gain for LoRaWAN, by default it is setup to 2.15 for all region except US (0.0) this means that whatever antenna you have TX power is always set to 13dBm you have no way to reduce or increase TX power.

Impact of changes

No change by default, allow to adapt TX power depending on antenna gain only by adding a new define

Documentation

To set TX power just add a new macro called LORAPHY_ANTENNA_GAIN with gain (float).

Example if you want to set TX power EU868 to 14dBm just add following in mbed_app.conf

    "macros": [
      "LORAPHY_ANTENNA_GAIN=1.15f"
    ]

Or add following in custom_targets.json

"macros_add": [  
  "LORAPHY_ANTENNA_GAIN=1.15f"
]

PS : I would love adding this parameter in mbed_lib.json of LoRaWAN but since antenna gain is not by default the same for each region, introducing default value of 2.15f would have introduce a breaking change for US915.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant @0xc0170


@mergify mergify bot added the needs: CI label Dec 19, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 19, 2023

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Dec 19, 2023
@mbed-ci
Copy link

mbed-ci commented Dec 19, 2023

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Dec 19, 2023
@0xc0170 0xc0170 merged commit baf6a30 into ARMmbed:master Dec 20, 2023
18 of 20 checks passed
@mergify mergify bot removed the ready for merge label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants