Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimxrt1050 lpuart #15382

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Mimxrt1050 lpuart #15382

merged 2 commits into from
Feb 22, 2023

Conversation

grumpyengineer
Copy link
Contributor

Summary of changes

MIMXRT1050_EVK and MIMXRT1170_EVK

Fix bug where calling set_format in MBED (which calls serial_format) causes the CTRL register to become corrupt due to saving its initial value to a uint8_t when the register is 32 bit wide

Change temp variable from uint8_t to uint32_t in serial_api.c

Fixes #15342

Impact of changes

Migration actions required

Documentation

None, bug fix to serial API


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Manually tested on MIMXRT1050_EVK, baud rate no longer changes to a random value after calling serialPort->set_format()

Not tested on a MIMXRT1170_EVK as I do not have access to one. Confirmed CTRL register is 32bit in section 71.5.1.8 of the MIMXRT1170 Reference Manual. The lpuart block appears identical across the 1050, 1060 and 1170 model range.


Reviewers


Fix bug where calling set_format in MBED (which calls serial_format) causes the CTRL register to become corrupt due to saving its initial value to a uint8_t when the register is 32 bit wide
Fix bug where calling set_format in MBED (which calls serial_format) causes the CTRL register to become corrupt due to saving its initial value to a uint8_t when the register is 32 bit wide
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Feb 22, 2023
@mbed-ci
Copy link

mbed-ci commented Feb 22, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIMXRT1050 lpuart bug when changing serial format
5 participants