Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scancode: Limit click version to <8 #15357

Merged
merged 1 commit into from
Dec 23, 2022
Merged

scancode: Limit click version to <8 #15357

merged 1 commit into from
Dec 23, 2022

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Dec 16, 2022 •
edited
Loading

Summary of changes

Due to the recent brakage one of components of scancode, they limit the scope of some components used in the core itself. Click has to be <8 to be compatible (we were fatching the latest).

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 0xc0170 changed the title Fixing scancode dependency issue WIP: Fixing scancode dependency issue Dec 16, 2022
@mergify mergify bot added the do not merge label Dec 16, 2022
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 16, 2022

packaging-22.0 is in the logs as I suspected...

Found it, https://github.com/nexB/scancode-toolkit/blob/develop/setup.cfg#L90 . I'll send PR fixing it there.

This was referenced Dec 16, 2022
Closed
Merged
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 20, 2022

The upstream is still not fixed :( I am waiting for review there.

@0xc0170
github: Fix click version
239a210 
Signed-off-by: Martin Kojtal <[email protected]>
@0xc0170 0xc0170 force-pushed the dev/martin.kojtal/fix-scancode-error-version branch from 1feace6 to 239a210 Compare December 22, 2022 13:57
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 22, 2022

scancode upstream was fixed. I rebased and added click version fix to be compatible with click. Let's see if its green again now

@0xc0170 0xc0170 changed the title WIP: Fixing scancode dependency issue scancode: Limit click version to <8 Dec 23, 2022
@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 23, 2022

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Dec 23, 2022
@0xc0170 0xc0170 merged commit c299c8b into ARMmbed:master Dec 23, 2022
@mergify mergify bot removed the ready for merge label Dec 23, 2022
@0xc0170 0xc0170 deleted the dev/martin.kojtal/fix-scancode-error-version branch December 23, 2022 14:26
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 6.17.0 release-version: 6.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xc0170 @adbridge @saheerb @mbedmain