Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unlock() in file_truncate in FATFileSystem #15306

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

horeich
Copy link
Contributor

@horeich horeich commented Jul 4, 2022

Summary of changes

Add unlock() to file_truncate in the FAT filesystem implementation of mbed. If using FATFileSystem::truncate(...) we run into a deadlock once the function is called from a different thread's context. This is due to the missing mutex unlock before the function is exited.

This issue has been reported here: [(https://github.com//issues/14613)]

Impact of changes

no implications

Migration actions required

not applicable

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 4, 2022
@ciarmcom
Copy link
Member

ciarmcom commented Jul 4, 2022

@horeich, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2022

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jul 4, 2022
@mbed-ci
Copy link

mbed-ci commented Jul 4, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@FabianInostroza
Copy link

That call is also missing in mbed-os 5.15

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2022

That call is also missing in mbed-os 5.15

Please create a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants