Add missing unlock() in file_truncate in FATFileSystem #15306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add unlock() to file_truncate in the FAT filesystem implementation of mbed. If using
FATFileSystem::truncate(...)
we run into a deadlock once the function is called from a different thread's context. This is due to the missing mutex unlock before the function is exited.This issue has been reported here: [(https://github.com//issues/14613)]
Impact of changes
no implications
Migration actions required
not applicable
Documentation
Pull request type
Test results
Reviewers