Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the possibility to customize the delimiter of the ATHandler in AT… #15273

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

Tobi15
Copy link
Contributor

@Tobi15 Tobi15 commented Apr 20, 2022

…CellularDevice class

Summary of changes

Modify the constructor of the ATCellularDevice to permit to customize ATHandler delimiter

Impact of changes

Migration actions required

Documentation

Basically there is no specific change for all applications. But after this change, it would be possible to modify the ATHandler delimiter. By default the value is "\r".


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

@Tobi15, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 21, 2022

Styling check failed (easy to fix), unittests failed (connectivity/cellular/tests/UNITTESTS/doubles/AT_CellularDevice_stub.cpp file requires an update)

0xc0170
0xc0170 previously approved these changes Apr 25, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 25, 2022

Basic Checks / style-check (pull_request)

It is failing due to styling errors, please review

@mergify mergify bot dismissed 0xc0170’s stale review May 10, 2022 12:31

Pull request has been modified.

@mergify mergify bot added needs: CI and removed needs: review labels May 11, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 10, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants