CMake: Fix command line too long with Ninja/ARMClang on Windows #15223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is reported in: ARMmbed#14533 And relies on bugfix in newer cmake version: https://gitlab.kitware.com/cmake/cmake/-/issues/21093
ciarmcom
added
the
release-type: patch
|
@ccli8, thank you for your changes. |
0xc0170
approved these changes
Feb 11, 2022
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.16.0
Release-pending
and removed
release-type: patch
ccli8
added a commit
to OpenNuvoton/NuMaker-mbed-Azure-IoT-CSDK-PnP-example
that referenced
this pull request
Apr 14, 2023
1. Upgrade to mbed-os 6.17.0
2. For CMake build, fix command line too long with Ninja/ARMClang on Windows
ARMmbed/mbed-os#15223
ccli8
added a commit
to OpenNuvoton/NuMaker-mbed-Azure-IoT-CSDK-PnP-example
that referenced
this pull request
Apr 14, 2023
1. Upgrade to mbed-os 6.17.0
2. For CMake build, fix command line too long with Ninja/ARMClang on Windows
ARMmbed/mbed-os#15223
ccli8
added a commit
to OpenNuvoton/NuMaker-mbed-Azure-IoT-CSDK-PnP-example
that referenced
this pull request
Apr 14, 2023
1. Upgrade to mbed-os 6.17.0
2. For CMake build, fix command line too long with Ninja/ARMClang on Windows
ARMmbed/mbed-os#15223
ccli8
added a commit
to OpenNuvoton/NuMaker-mbed-Azure-IoT-CSDK-DPS-example
that referenced
this pull request
Apr 14, 2023
1. Upgrade to mbed-os 6.17.0
2. For CMake build, fix command line too long with Ninja/ARMClang on Windows
ARMmbed/mbed-os#15223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR, relying on cmake bugfix, tries to fix the issue with ninja/armclang on windows. It is verified on cmake 3.22.0.
Pull request type
Test results