Fix STM32 radio driver when bandwidth is 0 #15217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
A bug was detected when the
uint8_t SUBGRF_GetFskBandwidthRegValue( uint32_t bandwidth )
is called and the bandwidth argument has a value of 0.
Comparing the code to the STMCubeWL 1.1 we can see that an if statement is missing to
address the condition where bandwidth is equal to 0.
Added the if statement to the radio driver to account for this edge case to prevent entering while (1) loop.
Impact of changes
Migration actions required
Documentation
None required.
But to replicate, I was using AS923-1, and then set my Gateway to have a maximum allowed data rate of DR_7.
The mBed device connected and quickly maxed out to DR_7 at which point the above function as called with bandwidth == 0.
Code from
radio_driver.c
(Line 1143):Pull request type
Test results
Reviewers
@jeromecoutant @hallard