Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nuvoton NuMaker-IoT-M263A CAN bus support #15207

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Add Nuvoton NuMaker-IoT-M263A CAN bus support #15207

merged 3 commits into from
Jan 28, 2022

Conversation

wally0258
Copy link
Contributor

@wally0258 wally0258 commented Jan 17, 2022 •
edited
Loading

Summary of changes

Add Nuvoton NuMaker-IoT-M263A CAN bus support

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Copied "can_api.c" file from "mbed-os\targets\TARGET_NUVOTON\TARGET_M451" and modify Pin according to NuMaker-IoT-M263A EVB.

Tested CAN transmit and receive on NuMaker-IoT-M263A EVB via "https://os.mbed.com/teams/Nuvoton/code/NuMaker-mbed-can/" sample code

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 17, 2022
@ciarmcom
Copy link
Member

@wally0258, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team January 17, 2022 07:00
@0xc0170 0xc0170 requested a review from a team January 24, 2022 10:32
0xc0170
0xc0170 previously requested changes Jan 24, 2022
View reviewed changes
targets/TARGET_NUVOTON/TARGET_M261/can_api.c Outdated Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 24, 2022

@wally0258 would you be able to add test logs or describe how this was tested?

@wally0258
Update can_api.c
94833a0 
Update Copyright
@mergify mergify bot dismissed 0xc0170’s stale review January 25, 2022 01:06

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 26, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 26, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

cyliangtw
cyliangtw suggested changes Jan 26, 2022
View reviewed changes
targets/TARGET_NUVOTON/TARGET_M261/can_api.c Outdated Show resolved Hide resolved
targets/TARGET_NUVOTON/TARGET_M261/can_api.c Outdated Show resolved Hide resolved
targets/TARGET_NUVOTON/TARGET_M261/can_api.c Show resolved Hide resolved
cyliangtw
cyliangtw approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@cyliangtw cyliangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 27, 2022

CI restarted

@mergify mergify bot added needs: CI and removed needs: work labels Jan 27, 2022
@mbed-ci
Copy link

mbed-ci commented Jan 27, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit f75ff22 into ARMmbed:master Jan 28, 2022
@mergify mergify bot removed the ready for merge label Jan 28, 2022
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@cyliangtw cyliangtw cyliangtw approved these changes

Assignees
No one assigned
Labels
devices: nuvoton release-version: 6.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wally0258 @ciarmcom @0xc0170 @mbed-ci @cyliangtw @mbedmain