Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Toshiba M4KN Platform #15194

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Add Toshiba M4KN Platform #15194

merged 3 commits into from
Jan 10, 2022

Conversation

deepak-shreshti
Copy link
Contributor

kindly Add mbed support for TOSHIBA's TMPM4KN board

Tested with all toolchains (GCC_ARM and ARM) and test results are attached
for GreenTea Test and CI shield Test.
M4KN_GreenteaAutomated_TestResult.txt
M4KN_CI-Test-Shield_TestReult.txt

M4KN_CI-Test-Shield_TestReult.txt
M4KN_GreenteaAutomated_TestResult.txt

@ciarmcom
Copy link
Member

@deepak-shreshti, thank you for your changes.
@ARMmbed/team-toshiba @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team December 11, 2021 09:00
0xc0170
0xc0170 previously requested changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targets/TARGET_TOSHIBA/TARGET_TMPM4KN/Periph_Driver/ files do not have SPDX neither the license text, see failing Basic check

Please add a license

@deepak-shreshti
Copy link
Contributor Author

targets/TARGET_TOSHIBA/TARGET_TMPM4KN/Periph_Driver/ files do not have SPDX neither the license text, see failing Basic check

Please add a license

Hi,
Yes we will resolve the reported issues.
However I have doubt w.r.t Python Test failing due to M4KN device name not added in index.json.
Basic Checks / python-tests (pull_request) Failing after 1m — python-tests
Can we edit the "index.json" file to add M4KN device name.
Note: arm pack for M4KN is "Toshiba.TXZ4Aplus-M4K2_DFP.1.0.0.pack" is available (https://www.keil.com/dd2/pack/)
in Keil website.

Best Regards
Deepak

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 15, 2021

Can we edit the "index.json" file to add M4KN device name.

Yes, that should fix it.

@mergify mergify bot dismissed 0xc0170’s stale review December 17, 2021 06:31

Pull request has been modified.

@deepak-shreshti
Copy link
Contributor Author

Hi

All tests have completed successfully , except CI test.
Toshiba has already sent M4KN Development Boards to Mbed Team.
The details for M4KN Development kit are updated in
https://os.mbed.com/platforms/TMPM4KN/
Kindly request you to perform CI test.

Best Regards
Deepak

0xc0170
0xc0170 previously approved these changes Dec 20, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Dec 20, 2021
@mbed-ci
Copy link

mbed-ci commented Dec 20, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ✔️

@mergify mergify bot added needs: work and removed needs: CI labels Dec 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2021

Ci failed, but only for gcc:

find . -name *.elf ! -path *wifi* ! -path *atecc608a* ! -path *lorawan* | xargs -I % python ../mbed-os/tools/test/examples/elf_float_checker.py %
Checking ./mbed-os-example-blinky/BUILD/TMPM4KN/GCC_ARM/mbed-os-example-blinky.elf for floating point symbols
Failed - Found float symbols:
__aeabi_dcmple
__aeabi_cdcmple
__aeabi_f2d
__aeabi_dsub
__aeabi_i2d
__aeabi_drsub
__aeabi_d2iz
__aeabi_ul2d
__aeabi_dmul
__aeabi_dcmpgt
__aeabi_cdcmpeq
__aeabi_cdrcmple
__aeabi_dcmpun
__aeabi_dcmpeq
__aeabi_dadd
__aeabi_dcmpge
__aeabi_ui2d
__aeabi_dcmplt
__aeabi_l2d
__aeabi_ddiv
Found float symbols in ./mbed-os-example-blinky/BUILD/TMPM4KN/GCC_ARM/mbed-os-example-blinky.elf

They should not be present, please verify

Deepak V. Shreshti added 3 commits December 23, 2021 19:19
Added M4KN Platform
44249f0 
New Platform M4KN for Toshiba has been added
Added SPDX Header
cd4ee72 
Updated PIN Names
Added M4KN MCU Deatils in index.json
Removed Special Chars
Updated code to remove float symbols
5bc3aa1
@mergify mergify bot dismissed 0xc0170’s stale review December 23, 2021 13:51

Pull request has been modified.

@deepak-shreshti
Copy link
Contributor Author

We have updated code.
Kindly run CI tests.

Best Regards
Deepak

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 29, 2021

CI started

@mergify mergify bot removed the needs: CI label Dec 29, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 30, 2021

I restarted CI (I assume it was internal network issue).

@mergify mergify bot added needs: work and removed needs: CI labels Dec 30, 2021
@mbed-ci
Copy link

mbed-ci commented Dec 30, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@deepak-shreshti
Copy link
Contributor Author

deepak-shreshti commented Dec 31, 2021 •
edited
Loading

I restarted CI (I assume it was internal network issue).

CI is failed again. There is no failure log found for our platform TMPM4KN in Jenkins logs.
Kindly provide the details of this failed case.

@deepak-shreshti
Copy link
Contributor Author

Could you please let us know how to proceed further

@deepak-shreshti
Copy link
Contributor Author

Dear Mbed Team,

Could you please let us know how to proceed further to complete TMPM4KN registration

Best Regards

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2022

@deepak-shreshti the most of the teams were away, sorry for the delay.

We will review the logs and find the root cause (this looks like CI issue rather than this pull request changes).

@mergify mergify bot added needs: work and removed needs: CI labels Jan 10, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2022

I can see the target failed nightly a week ago as well but the recent tests were all good. I restarted CI

@mbed-ci
Copy link

mbed-ci commented Jan 10, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 changed the title Added M4KN Platform Add M4KN Platform Jan 10, 2022
@0xc0170 0xc0170 changed the title Add M4KN Platform Add Toshiba M4KN Platform Jan 10, 2022
@0xc0170 0xc0170 merged commit 6bb606f into ARMmbed:master Jan 10, 2022
@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jan 10, 2022
@mergify mergify bot removed the ready for merge label Jan 10, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2022

I've noticed the first comment was not using the template (I added the release-type: patch manually). Please use the template, we use the information provided.

@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: toshiba release-version: 6.16.0 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deepak-shreshti @ciarmcom @0xc0170 @mbed-ci @mbedmain