nRF52: GPIO: Assert that init succeeds

[boraozgen]

Summary of changes

The issue with number of input interrupts was not fixed properly in #11622. If more InterruptIns are defined than configured with NRFX_GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS, the initialization failed silently and the additional inputs did not work. This change asserts that the initialization succeeds, so that the issue is at least visible to the developer.

Impact of changes

Migration actions required

Documentation

None

---

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[ciarmcom]

@boraozgen, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

[0xc0170]

CI started

[mbed-ci]

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

[0xc0170]

The failures look related, hal-tests-tests-mbed_hal_fpga_ci_test_shield-gpio_irq fails for NRF52 with fpga shield.

Are we hitting the assert (too many irq inputs under tests for this platform) ?

[boraozgen]

Probably they hit the assert, but I'm not sure if the number of inputs is the reason, as the tests were working before, the inputs must have worked properly. Maybe the function returns another code in some cases, it is hard to tell.

I'll try to look into it, but we could drop this PR if it continues to fail and make sure that the configuration is documented properly.

Pull request has been modified.

[boraozgen]

It seems that the init functions are returning NRFX_ERROR_INVALID_STATE in case the pin is already used. This might be the issue. I changed the assert so that it checks for the actual error which is received when the number of inputs exceed the configuration.

mbed-os/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_SDK_15_0/modules/nrfx/drivers/include/nrfx_gpiote.h

Lines 307 to 332 in ff061e8

	/**
	* @brief Function for initializing a GPIOTE input pin.
	* @details The input pin can act in two ways:
	* - lower accuracy but low power (high frequency clock not needed)
	* - higher accuracy (high frequency clock required)
	*
	* The initial configuration specifies which mode is used.
	* If high-accuracy mode is used, the driver attempts to allocate one
	* of the available GPIOTE channels. If no channel is
	* available, an error is returned.
	* In low accuracy mode SENSE feature is used. In this case only one active pin
	* can be detected at a time. It can be worked around by setting all of the used
	* low accuracy pins to toggle mode.
	* For more information about SENSE functionality, refer to Product Specification.
	*
	* @param[in] pin Pin.
	* @param[in] p_config Initial configuration.
	* @param[in] evt_handler User function to be called when the configured transition occurs.
	*
	* @retval NRFX_SUCCESS If initialization was successful.
	* @retval NRFX_ERROR_INVALID_STATE If the driver is not initialized or the pin is already used.
	* @retval NRFX_ERROR_NO_MEM If no GPIOTE channel is available.
	*/
	nrfx_err_t nrfx_gpiote_in_init(nrfx_gpiote_pin_t pin,
	nrfx_gpiote_in_config_t const * p_config,
	nrfx_gpiote_evt_handler_t evt_handler);

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️