Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WL : add robustness #15183

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Sometimes lorawan test was not 100% OK when it is executed many times.

@ludoch-stm
@hallard

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 29, 2021
@ciarmcom ciarmcom requested a review from a team November 29, 2021 15:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2021

Can you extend the commit message "add robustness" - where (is this lorawan), also what is this addressing - is there a bug or improvement?

@jeromecoutant jeromecoutant force-pushed the STM32WL_UPDATE branch 2 times, most recently from c966d42 to 51be1d4 Compare November 29, 2021 17:11
0xc0170
0xc0170 previously requested changes Dec 6, 2021
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder if we should document export deprecated feature


## CUSTOM boards
`mbed export -m NUCLEO_WL55JC -i uvision6`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be part of this PR neither the commit (not related to the PR ,is it?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about WL... :-)
I could make 2 commits at least !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true lets separate these. Should we however document deprecated features (at least a note there ?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 done

@mergify mergify bot dismissed 0xc0170’s stale review December 6, 2021 16:50

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2021

Ci started

@mergify mergify bot added needs: CI and removed needs: work labels Dec 6, 2021
@mbed-ci
Copy link

mbed-ci commented Dec 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit a82ee22 into ARMmbed:master Dec 7, 2021
@mergify mergify bot removed the ready for merge label Dec 7, 2021
@jeromecoutant jeromecoutant deleted the STM32WL_UPDATE branch December 7, 2021 15:44
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants