Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LoRa sx1276 Low Power sleep, now 3uA #15181

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix LoRa sx1276 Low Power sleep, now 3uA #15181

merged 1 commit into from
Dec 8, 2021

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Nov 29, 2021

Summary of changes

Replace #15180 cleaner

Fix sx1276 #227
May be same patch could be applied to #14224 (sx1272 and sx126x) but I have nothing to test

Impact of changes

Management of TCXO is now working fine
return DIO mapping of sx1276 to low power state

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 , @jeromecoutant , @MarceloSalazar

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 29, 2021
@ciarmcom
Copy link
Member

@hallard, thank you for your changes.
@0xc0170 @MarceloSalazar @jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@hallard hallard changed the title Fix Low Power sleep, now 3uA Fix LoRa sx1276 Low Power sleep, now 3uA Nov 29, 2021
@hallard hallard mentioned this pull request Nov 29, 2021
Closed
jeromecoutant
jeromecoutant suggested changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lora test can not connect with DISCO_L072CZ_LRWAN1

@hallard
Copy link
Contributor Author

hallard commented Nov 29, 2021

Lora test can not connect with DISCO_L072CZ_LRWAN1

Yeah may be delay, let us check that, it was working on murata module so same as DISCO_L072CZ_LRWAN1, that's strange your board can't connect

@hallard hallard force-pushed the LoRa_sx1276_LowPower_fix branch 2 times, most recently from 1db344e to 81e0301 Compare November 29, 2021 16:13
mickael868
mickael868 reviewed Nov 29, 2021
View reviewed changes
connectivity/drivers/lora/COMPONENT_SX1276/SX1276_LoRaRadio.cpp
if (_rf_ctrls.tcxo != NC) {
_tcxo = 1;
// TCXO startup time
ThisThread::sleep_for(5ms);
Copy link

@mickael868 mickael868 Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the tests I did on a custom Murata-based board, if the sleep period is greater or equal to 9ms, the device is unable to receive a join accept.

Copy link
Contributor Author

@hallard hallard Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mickael868, this mean that 5ms looks like correct value (no magic, I took this 5ms from code of other stack).
Pay attention to SPI, SPI communication with sx1272 won't work if TCXO is not enabled. Worth mentioning this one
@jeromecoutant could you please confirm it now works with your DISCO_L072CZ_LRWAN1 ?

@jeromecoutant
Copy link
Collaborator

@0xc0170 let's start CI ?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Dec 8, 2021
@mbed-ci
Copy link

mbed-ci commented Dec 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 1c5813b into ARMmbed:master Dec 8, 2021
@mergify mergify bot removed the ready for merge label Dec 8, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 20, 2022
@hallard hallard deleted the LoRa_sx1276_LowPower_fix branch July 3, 2022 17:25
@0xc0170 0xc0170 mentioned this pull request Jul 22, 2022
Closed
@hallard hallard mentioned this pull request Aug 17, 2022
Closed
@hallard hallard mentioned this pull request Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickael868 mickael868 mickael868 left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
component: connectivity release-version: 6.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hallard @ciarmcom @jeromecoutant @0xc0170 @mbed-ci @mickael868 @mbedmain