Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mstd::span rename index_type to size_type according to spec #15176

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

marcemmers
Copy link
Contributor

Summary of changes

Renames the size type in mstd::span from index_type to size_type according to the spec, see https://en.cppreference.com/w/cpp/container/span member types. Ran into this issue when trying to implement the c++23 spanstream classes that are using the size_type from span.

Impact of changes

This is breaking for everyone that used the index_type of the span. No functional changes though.

Migration actions required

Rename all usages of span<>::index_type to span<>::size_type

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 24, 2021
@ciarmcom
Copy link
Member

@marcemmers, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@pan-
Copy link
Member

pan- commented Nov 25, 2021

@marcemmers Maybe the previous alias can kept to avoid breaking existing applications.

@marcemmers
Copy link
Contributor Author

@marcemmers Maybe the previous alias can kept to avoid breaking existing applications.

That's possible of course. Would you prefer it if I made the index type deprecated then? Like:

using index_type [[deprecated("Use size_type instead.")]] = size_t;

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2021

@marcemmers let's do nonbreaking fix

@mergify mergify bot added needs: CI and removed needs: review labels Dec 7, 2021
@0xc0170 0xc0170 requested a review from pan- December 7, 2021 14:02
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 810662b into ARMmbed:master Dec 9, 2021
@mergify mergify bot removed the ready for merge label Dec 9, 2021
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants