Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WL update drivers version to CUBE V1.1.0 #15137

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

ST Cube drivers version is updated from V1.0.0 to V1.1.0
which is the latest official version from:

https://github.com/STMicroelectronics/STM32CubeWL/

I remind the STM32 custom board repo: https://github.com/ARMmbed/stm32customtargets

@ludoch-stm @hallard @niondir

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 12, 2021
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 13, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2021

CI started

@hallard
Copy link
Contributor

hallard commented Oct 13, 2021

I made one change in #15017 on the driver, so this one will override this change.
But what I suspected (due to HW matching) is happening
https://forum.seeedstudio.com/t/lora-e5-fw-bug-tx-eu868-85ma-too-high-consumption/260126
This mean that my old PR will decrease consumption but also range as soon as distance increase.
We have no magic solution because the design done by RAK and Seeed are not optimal for STM32WL, they decided not using RF_LP path which put us in this bad situation for EU868 so I would give up and revert back my changes.
So merging this new PR (erasing #15017) sounds good to me.
May be best could be to have an option to decide to compile for Low Power or Long Range for these devices?

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@jeromecoutant
Copy link
Collaborator Author

I made one change in #15017 on the driver, so this one will override this change.

No.. this PR doesn't affect connectivity/drivers/lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp

@hallard
Copy link
Contributor

hallard commented Oct 13, 2021

No.. this PR doesn't affect connectivity/drivers/lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp

by bad, looked too fast on CMake and saw the cpp file was changed, bad assumption

@jeromecoutant
Copy link
Collaborator Author

Do you need time to test this PR and approve,
or do you think this will be OK for you ?
Thx

@hallard
Copy link
Contributor

hallard commented Oct 13, 2021

Switched on other topics right now, but on driver side should be ok since I tested on V1.1.0 STMCube last month.

I will try to give a test quickly

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2021

In that case, I'll merge once confirmed

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2021

I'll merge this. If there is any issue, please create a new bug report.

@0xc0170 0xc0170 merged commit 06f234e into ARMmbed:master Oct 15, 2021
@mergify mergify bot removed the ready for merge label Oct 15, 2021
@jeromecoutant jeromecoutant deleted the PR_WL_1_1_0 branch October 15, 2021 08:08
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants