Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32WB/STM32WL: I2C issue #15133

Merged
merged 1 commit into from
Oct 12, 2021
Merged

STM32WB/STM32WL: I2C issue #15133

merged 1 commit into from
Oct 12, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

We got an assert if the application was using I2C1 with a STM32WL

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 8, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Oct 8, 2021

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team October 8, 2021 12:00
0xc0170
0xc0170 previously requested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add details to the commit message, it's not clear what i2c issue is this fixing

@jeromecoutant
STM32Wx: I2C issue
035b787 
a "else" was missing for

uint32_t i2c_get_pclk(I2CName i2c)
    if (i2c == I2C_1) {
    else if (i2c == I2C_2) {
    else if (i2c == I2C_3) {
    else {
        error("I2C: unknown instance");
@jeromecoutant
Copy link
Collaborator Author

Can you add details to the commit message, it's not clear what i2c issue is this fixing

Done

@mergify mergify bot dismissed 0xc0170’s stale review October 12, 2021 10:02

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 12, 2021

CI restared

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 3167a1f into ARMmbed:master Oct 12, 2021
@mergify mergify bot removed the ready for merge label Oct 12, 2021
@jeromecoutant jeromecoutant deleted the PR_I2C branch October 13, 2021 07:21
@jeromecoutant jeromecoutant mentioned this pull request Nov 22, 2021
Closed
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.15.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @mbedmain