Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: fix USB_reenumerate() for STM32F3 #15132

Merged
merged 1 commit into from
Oct 11, 2021
Merged

STM32: fix USB_reenumerate() for STM32F3 #15132

merged 1 commit into from
Oct 11, 2021

Conversation

douardda
Copy link
Contributor

@douardda douardda commented Oct 7, 2021

for which the DP pin remained forced low after the reenumerate sequence
(low for 10ms) instead of being reconfigured as an input (PullNone).

Signed-off-by: David Douard [email protected]

Summary of changes

Fix the USB device driver for the STM32F3 series.

The USB_reenumerate() function was keeping the DP pin configured as an output after pulling it low for 10ms for the enumeration process.

Fixes #15112

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@douardda
STM32: fix USB_reenumerate() for STM32F3
d5d93a4 
for which the DP pin remained forced low after the reenumerate sequence
(low for 10ms) instead of being reconfigured as an input (PullNone).

Signed-off-by: David Douard <[email protected]>
@douardda douardda mentioned this pull request Oct 7, 2021
Closed
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 7, 2021
@ciarmcom ciarmcom requested review from jeromecoutant and a team October 7, 2021 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 7, 2021

@douardda, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 11, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit b7c2dd0 into ARMmbed:master Oct 11, 2021
@mergify mergify bot removed the ready for merge label Oct 11, 2021
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.15.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STM32F303RD: USB: unable to enumerate USB device
6 participants
@douardda @ciarmcom @0xc0170 @mbed-ci @jeromecoutant @mbedmain