Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix USB on DISCO_F769NI #15128

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Fix USB on DISCO_F769NI #15128

merged 2 commits into from
Oct 7, 2021

Conversation

Jookia
Copy link
Contributor

@Jookia Jookia commented Oct 6, 2021

Summary of changes

Fixes USB device support on the DISCO_F769NI target.
Related to #14564 .

Impact of changes

Migration actions required

Documentation

The existing target code and configuration contains two issues:

  • The wrong pins are set to ULPI mode
  • The targets.json file does not use ULPI mode

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

I'm not sure what kind of test this needs.
Running the USBCDC example from https://os.mbed.com/docs/mbed-os/v6.15/apis/usbcdc.html works.
Without this patch the device does not even enumerate to Linux.


Reviewers


These pins are not connected to the USB PHY, so don't set their
alternate function as such.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 6, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Oct 6, 2021

@Jookia, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@jeromecoutant
Copy link
Collaborator

@Jookia
Copy link
Contributor Author

Jookia commented Oct 6, 2021

I thought about doing that, but I wouldn't be able to test it. The best I can do is check schematics.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 7, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Oct 7, 2021
@mbed-ci
Copy link

mbed-ci commented Oct 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 76c3720 into ARMmbed:master Oct 7, 2021
@mergify mergify bot removed the ready for merge label Oct 7, 2021
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
@Jookia Jookia deleted the RFC_usbfix branch March 21, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants