CLI2: copy mapfile for diff statistics #15117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the greentea test complains about 'The full profile is not supported for this Mbed target' for compililing a target G031 with baremetal profile. Looks like some configuration problem or is it a side affect of older cmake version? |
|
@JojoS62, thank you for your changes. |
ithinuel
reviewed
Sep 28, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
reviewed
Oct 12, 2021
|
CI started |
|
Note, when we merge, we will squash commits into 1 |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Oct 14, 2021
|
Ci restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Oct 14, 2021
mbedmain
added
release-version: 6.15.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
copy the linker map file to target.elf.map.old. The memap.py statistics generator looks for a given filename +'.old'. If it exists, it generates the difference to previous module sizes as with CLI1.
Current behaviour is not copy the map file, so this feature is not yet available in CLI2 builds.
This PR replaces my previous attempt #15110
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers