Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MAX32660EVSYS #15109

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Add MAX32660EVSYS #15109

merged 7 commits into from
Oct 12, 2021

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Sep 27, 2021 •
edited
Loading

  • Add SDK files (updated to match mbed system)
  • Implement mbed API files
  • Update mbed related configuration (CMakefiles, .json files...)
  • Add gcc and arm related files (linker, scatter, startup...)
  • Tested with ARM and GCC_ARM toolchain
  • GreenTea tests have been executed

MAX32660EVSYS_TestResult_20210930_ARM.txt
MAX32660EVSYS_TestResult_20210930_GCC_ARM.txt

Signed-off-by: Sadik.Ozer [email protected]

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team September 27, 2021 09:00
@ciarmcom
Copy link
Member

@ozersa, thank you for your changes.
@ARMmbed/team-maximintegrated @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2021

Please review failures, related to the changes (missing CMakeLists for instance).

@ozersa
Copy link
Contributor Author

ozersa commented Sep 27, 2021

Added CMakeLists files.

@ozersa ozersa force-pushed the add-MAX32660 branch 2 times, most recently from 5b6e15c to e9dbe5f Compare September 29, 2021 06:13
@MarceloSalazar
Copy link

MarceloSalazar commented Sep 29, 2021 •
edited
Loading

@ozersa there are two failures in the tests. These should be fixed before we start a review. Thanks!

Add MAX32660EVSYS
9c029bf 
- Add SDK files (updated to match mbed system)
- Implement mbed API files
- Update mbed related configuration (CMakefiles, .json files...)
- Add gcc and arm related files (linker, scatter, startup...)
- Tested with ARM and GCC_ARM toolchain
- GreenTea tests have been executed

Signed-off-by: Sadik.Ozer <[email protected]>
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2021

@ozersa Once you update the pull request, it's nice to add a message what has changed. I assume the failures were addressed and this is ready for CI

@ozersa
Copy link
Contributor Author

ozersa commented Oct 4, 2021

Yes it is ready for CI. Thank you for reminder.

I had informed @MarceloSalazar over email. Sorry to not updated here too.

0xc0170
0xc0170 previously requested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me.

targets/TARGET_Maxim/TARGET_MAX32660/watchdog_api.c Outdated
MXC_WDT_EnableReset(MXC_WDT0);

//NVIC_SetVector(WDT0_IRQn, WDT0_IRQHandler);
//NVIC_EnableIRQ(WDT0_IRQn);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mergify mergify bot dismissed 0xc0170’s stale review October 4, 2021 09:59

Pull request has been modified.

0xc0170
0xc0170 previously approved these changes Oct 4, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Oct 4, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 7, 2021

New only armclang failure, it can't find a file (cmake test job).

@ozersa
Copy link
Contributor Author

ozersa commented Oct 7, 2021

image

In fact, The file in the correct location. It works for GCC side.
image

I do not have ARM toolchain I will try to run this command over MBED studio.

@ozersa
Copy link
Contributor Author

ozersa commented Oct 7, 2021

@0xc0170 could you take a look to this issue,
I am not able to execute command on my local, I installed arm toolchain but because of license issue not able to execute it on command line,
image

Over MBED studio I got different configuration related errors....
image

@ozersa
Copy link
Contributor Author

ozersa commented Oct 7, 2021

@MarceloSalazar FYI.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 7, 2021 •
edited
Loading

I found an error,

mbed-os/targets/TARGET_Maxim/TARGET_MAX32660/CMakeLists.txt

Line 8 in 4db4364

set(STARTUP_FILE device/TOOLCHAIN_ARM_STD/startup_MAX32660.S)
- the file name is incorrect (MAX instead of max), thus it can't find it. It should be startup_max32660

Use lower case
b8bef04 
Signed-off-by: Sadik.Ozer <[email protected]>
@ozersa
Copy link
Contributor Author

ozersa commented Oct 7, 2021

Thank you, l looked there ~10 times but not see these capital case.
Could you restart CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 7, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️

@ozersa
Copy link
Contributor Author

ozersa commented Oct 7, 2021

Added watchdog_api.c file in CMakelist.txt,
One more please,
all them worked on gcc and mbed studio side...

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

tugrulyatagan
tugrulyatagan approved these changes Oct 8, 2021
View reviewed changes
Copy link

@tugrulyatagan tugrulyatagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ozersa
Copy link
Contributor Author

ozersa commented Oct 12, 2021

@0xc0170 Will it be merged into master before next MBED release (v6.16) ?

@0xc0170 0xc0170 merged commit 34bbc75 into ARMmbed:master Oct 12, 2021
@mergify mergify bot removed the ready for merge label Oct 12, 2021
@mergify
Copy link

mergify bot commented Oct 12, 2021

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Oct 12, 2021
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Oct 12, 2021
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugrulyatagan tugrulyatagan tugrulyatagan approved these changes

@ahmetalincak ahmetalincak ahmetalincak approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
devices: maxim release-version: 6.15.1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ozersa @ciarmcom @0xc0170 @MarceloSalazar @mbed-ci @idea--list @tugrulyatagan @ahmetalincak @mbedmain