Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWIP: Provide inline replacements for htons() and htonl() #15107

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

ndrs-pst
Copy link
Contributor

@ndrs-pst ndrs-pst commented Sep 25, 2021

Summary of changes

Since LWIP version 2.1.0 provide the way to supply assembly or inline replacements for htons() and htonl()

Impact of changes

CMSIS intrinsic function __REV16 and __REV will be used instead of default implementation in lwip_def.c
#define lwip_htons(x) __REV16(x)
#define lwip_htonl(x) __REV(x)

Significant reduce of code sizes and also MCU cycles 馃殌

Migration actions required

None

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

@ndrs-pst, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Sep 28, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Sep 28, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 28, 2021

I set this to patch release, if that is OK. This should not change the functionality.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 28, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 28, 2021

Jenkins CI Test : 鉁旓笍 SUCCESS

Build Number: 1 | 馃敀 Jenkins CI Job | 馃寪 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests 鉁旓笍
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-cloud-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-greentea-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_greentea-test 鉁旓笍

@0xc0170 0xc0170 merged commit 4851f6c into ARMmbed:master Sep 29, 2021
@mergify mergify bot removed the ready for merge label Sep 29, 2021
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants