Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32H7: enable more custom boards #15099

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Many custom boards are embedding STM32H7xx MCU

This PR enables them

See https://github.com/ARMmbed/stm32customtargets/tree/GENERIC_TARGET/

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


- STM32H723xG
- STM32H725xE
- STM32H750xB
Add
- STM32H723ZGTx for all STM32H723xG targets
- STM32H725AEIx for all STM32H725xE targets
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 22, 2021
@ciarmcom ciarmcom requested a review from a team September 22, 2021 13:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@0xc0170 0xc0170 removed the stale Stale Pull Request label Sep 28, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Sep 28, 2021
@0xc0170 0xc0170 removed the stale Stale Pull Request label Sep 29, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Sep 29, 2021
@mbed-ci
Copy link

mbed-ci commented Sep 29, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 0b9a774 into ARMmbed:master Sep 29, 2021
@mergify mergify bot removed the ready for merge label Sep 29, 2021
@jeromecoutant jeromecoutant deleted the PR_H723 branch September 29, 2021 14:30
@JojoS62
Copy link
Contributor

JojoS62 commented Sep 29, 2021

will there be also support for STM32H735IG? This one is on a Discovery board which has no Mbed support yet.

clocksource = __HAL_RCC_GET_I2C5_SOURCE();
switch (clocksource) {
case RCC_I2C5CLKSOURCE_D2PCLK1:
pclk = HAL_RCCEx_GetD2PCLK1Freq();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant HAL_RCCEx_GetD2PCLK1Freq() does not seem to exist anywhere.

Similar function exist, but not for D2PCLK1:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
See #15229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants