connectivity tests: avoid HardFault with null pointer #15068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant, thank you for your changes. |
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, @ARMmbed/mbed-os-connectivity, please complete review of the changes to move the PR forward. Thank you for your contributions. |
0xc0170
added
the
release-type: patch
0xc0170
reviewed
Sep 28, 2021
| @@ -30,6 +30,10 @@ using namespace utest::v1; | |||
| void wifi_connect(void) | |||
| { | |||
| WiFiInterface *wifi = get_interface(); | |||
| TEST_ASSERT(wifi); | |||
| if (wifi == NULL) { | |||
There was a problem hiding this comment.
what's the difference between wifi tests returning (assert before) and asserting with a message (TEST_ASSERT_NOT_NULL_MESSAGE not in this case)
There was a problem hiding this comment.
Other tests are stopping as soon as a test assert comes.
This one doesn't stop, so it needs a "clean" return.
|
Let's start CI ? |
0xc0170
approved these changes
Oct 13, 2021
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.15.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Issue occurs with wrong mbed setup,
for example if you forget to config the correct IP interface.
In this case tests are crashing into HardFault.
Proposition is to check the interface pointer in each tests.
Now tests are failing with more explicit status.
Thx
Impact of changes
none for well configured setup :-)
Migration actions required
Documentation
Pull request type
Test results
Reviewers