Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greentea: Fix flash overflown issue in callback_big test #15067

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Greentea: Fix flash overflown issue in callback_big test #15067

merged 1 commit into from
Sep 14, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Sep 13, 2021 •
edited
Loading

Summary of changes

The "Callback_big" greentea test has six test cases that require a minimum above 36kb ROM to build all test cases. LPC1114 target has only 32KB ROM memory, so the limit 6th test case to include or exclude based on the target minimum ROM size

Note:
In LPC1114 target, callback_big test has ROM overflow build issue for both Mbed CLI1 and CLI2.

Impact of changes

With these changes, Callback_big greentea test can avoid overflow ROM issue

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 13, 2021
@ciarmcom ciarmcom requested a review from a team September 13, 2021 13:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@rajkan01 rajkan01 force-pushed the fix_flash_overflow_callback_big_test branch from ed03ab3 to 4f6efb2 Compare September 13, 2021 13:33
Patater
Patater previously requested changes Sep 13, 2021
View reviewed changes
platform/tests/TESTS/mbed_functional/callback/main.cpp Outdated Show resolved Hide resolved
platform/tests/TESTS/mbed_functional/callback/main.cpp Outdated Show resolved Hide resolved
@rajkan01 rajkan01 force-pushed the fix_flash_overflow_callback_big_test branch from 4f6efb2 to c5221ef Compare September 13, 2021 13:53
@mergify mergify bot dismissed Patater’s stale review September 13, 2021 13:53

Pull request has been modified.

@rajkan01
Greentea: Fix flash overflown issue in callback_big test
77960d3 
The "Callback_big" greentea test has six test cases that require
a minimum above 36kb ROM to build all test cases. LPC1114 target
has only 32KB ROM memory, so the limit 6th test case to include
or exclude based on the target minimum ROM size.

Note:
In LPC1114 target, callback_big test has ROM overflow build issue
for both Mbed CLI1 and CLI2.
@rajkan01 rajkan01 force-pushed the fix_flash_overflow_callback_big_test branch from c5221ef to 77960d3 Compare September 14, 2021 14:28
Patater
Patater approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater
Copy link
Contributor

Patater commented Sep 14, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: work labels Sep 14, 2021
@mbed-ci
Copy link

mbed-ci commented Sep 14, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@Patater Patater merged commit eff8fda into master Sep 14, 2021
@mergify mergify bot removed the ready for merge label Sep 14, 2021
@Patater Patater added this to In progress (8) in Mbed Core via automation Sep 14, 2021
@Patater Patater moved this from In progress (8) to Done in Mbed Core Sep 14, 2021
@rajkan01 rajkan01 mentioned this pull request Sep 16, 2021
Closed
@Patater Patater moved this from Done to Reported in Mbed Core Sep 17, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 21, 2021
@0xc0170 0xc0170 deleted the fix_flash_overflow_callback_big_test branch October 5, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

Assignees
No one assigned
Labels
component: core release-version: 6.15.0
Projects
No open projects
Mbed Core
  
Reported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajkan01 @ciarmcom @Patater @mbed-ci @rwalton-arm @mbedmain