CMake: Fix platform wait_ns greentea test Cmake #15066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
Patater
previously requested changes
Sep 13, 2021
Mbed CLI 2 generates TARGET_ARM_FM macro as a string in mbed_config.cmake under the MBED_TARGET_DEFINITIONS list. Fix the "if defined" check for TARGET_ARM_FM by searching for the TARGET_ARM_FM string in the MBED_TARGET_DEFINITIONS list. This allows us to skip or include the test from CMake.
rajkan01
force-pushed
the
fix_platform_wait_ns_test_cmake
branch
from
a8f1d5b
to
ad18cc8
Compare
mergify
bot
dismissed
Patater’s stale review
Pull request has been modified.
|
@rajkan01, thank you for your changes. |
LDong-Arm
approved these changes
Sep 13, 2021
Patater
approved these changes
Sep 14, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Mbed CLI 2 generates TARGET_ARM_FM macro as a string in mbed_config.cmake under the MBED_TARGET_DEFINITIONS list. Fix the
if definedcheck for TARGET_ARM_FM by searching for the TARGET_ARM_FM string in the MBED_TARGET_DEFINITIONS list. This allows us to skip or include the test from CMake.Impact of changes
With these changes, greentea test run by Ctest can able to skip/include the platform/wait_ns test
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers