Fix replacement of event queue background. #15061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When an existing background function is replaced from the event queue, first reset the existing one to nullptr then set the new one as they share the same memory location.
Otherwise, equeue_background won't terminate the old callback (or worse call into a nullptr).
This was discovered when EventQueue::background was called with a nullptr.
It crashes the software as it tries to call into a nullptr.
Impact of changes
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers