Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement of event queue background. #15061

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

pan-
Copy link
Member

@pan- pan- commented Sep 9, 2021

Summary of changes

When an existing background function is replaced from the event queue, first reset the existing one to nullptr then set the new one as they share the same memory location.
Otherwise, equeue_background won't terminate the old callback (or worse call into a nullptr).

This was discovered when EventQueue::background was called with a nullptr.
It crashes the software as it tries to call into a nullptr.

Impact of changes

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 9, 2021
@ciarmcom ciarmcom requested a review from a team September 9, 2021 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Sep 9, 2021

@pan-, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Sep 9, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 9, 2021

Should there be test case added to catch this?

@0xc0170 0xc0170 self-requested a review September 9, 2021 09:04
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 9, 2021

Styling check failed (empty spaces at the end of lines?)

This was discovered when EventQueue::background was called with a nullptr.
It crashes the software as it tries to call into a nullptr.
@pan- pan- force-pushed the fix-event-queue-background-fn-change branch from e6c741f to db4b02c Compare September 10, 2021 11:13
@mergify mergify bot dismissed 0xc0170’s stale review September 10, 2021 11:13

Pull request has been modified.

@mergify mergify bot added needs: CI and removed needs: review labels Sep 10, 2021
@mbed-ci
Copy link

mbed-ci commented Sep 13, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@adbridge adbridge merged commit 7feef59 into ARMmbed:master Sep 16, 2021
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants