New feature: send/recv message implementation added to network stack #15040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mat-kalinowski, thank you for your changes. |
|
If you rebase to the latest master, license check should stop failing with python error. Also review styling check - code needs fixing. |
|
I have added some changes to solve the bugs present in the unit tests:
|
This patch contains improvements mentioned in the unresolved PR comments: - function names were changed from socket_sendmsg/socket_recvmsg to socket_sendto_control/socket_recvfrom_control. - default implementation of this functions was provided in the NetworkStack class. - MsgHeaderIterator accesses elements on the aligned addresses.
ad047e3
to
ec3f437
Compare
pan-
reviewed
Sep 3, 2021
Doxygen documentation for MsgHeaderIterator was added. Type used for alignment of the nsapi_msghdr_t struct was changed.
Minor errors in the documentation were fixed. These caused failure of the doxygen checks in the PR.
pan-
previously approved these changes
Sep 6, 2021
0xc0170
previously requested changes
Sep 6, 2021
connectivity/netsocket/tests/UNITTESTS/netsocket/NetworkStack/test_MsgHeaderIterator.cpp
Outdated
Show resolved
Hide resolved
| nsapi_size_or_error_t TCPSocket::sendto_control(const SocketAddress &address, const void *data, nsapi_size_t size, | ||
| nsapi_msghdr_t *control, nsapi_size_t control_size) | ||
| { | ||
| // FIXME: Implement |
There was a problem hiding this comment.
Can you rather create an tracking issue for this and remove the comment (reference the issue in the commit message, it can be easily found then)
There was a problem hiding this comment.
Done, new issue - #15057
There was a problem hiding this comment.
Issue number should be added in the amended commit message when merging this PR into master
|
@0xc0170 Yes a doc update is required, I'm doing it. |
Pull request has been modified.
pan-
previously approved these changes
Sep 8, 2021
0xc0170
previously approved these changes
Sep 8, 2021
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
The build errors are related, please review the logs |
Macro MBED_ALIGN expands in C to _Alignas which can't be used in the type declaration. This patch moves it to the first type definition which makes this code compile properly in CPP and C.
Pull request has been modified.
Done, It should work fine now |
pan-
approved these changes
Sep 8, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR is continuation of another stale PR: #14847. I am opening this one, as I didn't have access to push to the fork created by other developer.
I have added few changes related to unresolved comments:
.
Impact of changes
Migration actions required
Documentation
Stale PR with this feature:
#14847
Pull request type
Test results
Reviewers
@pan-