Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2354: Fix LCDCP missing in TF-M CLK pass list #15030

Merged
merged 1 commit into from
Sep 2, 2021
Merged

M2354: Fix LCDCP missing in TF-M CLK pass list #15030

merged 1 commit into from
Sep 2, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Aug 31, 2021

Summary of changes

This PR fixes LCDCP_MODULE missing in TF-M pass list for below BSP CLK driver in NSPE:

  • CLK_SetModuleClock_S
  • CLK_EnableModuleClock_S
  • CLK_DisableModuleClock_S
  • CLK_GetModuleClockSource_S

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 31, 2021
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 31, 2021 10:00
LDong-Arm
LDong-Arm previously approved these changes Aug 31, 2021
View reviewed changes
@LDong-Arm LDong-Arm added this to In progress (8) in Mbed Core via automation Aug 31, 2021
@LDong-Arm LDong-Arm mentioned this pull request Aug 31, 2021
Closed
Mbed Core automation moved this from In progress (8) to Reviewer approved & awaiting CI & merge (3) Sep 1, 2021
0xc0170
0xc0170 previously approved these changes Sep 1, 2021
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 1, 2021

@ccli8 Please rebase to the latest master to fix basic checks failures (fixed on master already), we can start CI afterwards.

@ccli8
M2354: Fix LCDCP missing in TF-M CLK pass list
6447b3d 
Besides LCD_MODULE, add LCDCP_MODULE into TF-M pass list for below CLK driver in NSPE:

-   CLK_SetModuleClock_S
-   CLK_EnableModuleClock_S
-   CLK_DisableModuleClock_S
-   CLK_GetModuleClockSource_S
@ccli8 ccli8 force-pushed the nuvoton_m2354_tfm_missing_lcdcp branch from 1f5e102 to 6447b3d Compare September 2, 2021 01:17
@mergify mergify bot dismissed stale reviews from LDong-Arm and 0xc0170 September 2, 2021 01:18

Pull request has been modified.

Mbed Core automation moved this from Reviewer approved & awaiting CI & merge (3) to Review in progress (4) Sep 2, 2021
@ccli8
Copy link
Contributor Author

ccli8 commented Sep 2, 2021

Rebased

@ccli8 ccli8 mentioned this pull request Sep 2, 2021
Merged
LDong-Arm
LDong-Arm approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mbed Core automation moved this from Review in progress (4) to Reviewer approved & awaiting CI & merge (3) Sep 2, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Sep 2, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 887bcf7 into ARMmbed:master Sep 2, 2021
Mbed Core automation moved this from Reviewer approved & awaiting CI & merge (3) to Done Sep 2, 2021
@mergify mergify bot removed the ready for merge label Sep 2, 2021
@ccli8 ccli8 deleted the nuvoton_m2354_tfm_missing_lcdcp branch September 3, 2021 01:11
@Patater Patater moved this from Done to Reported in Mbed Core Sep 10, 2021
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
devices: nuvoton release-version: 6.15.0
Projects
No open projects
Mbed Core
  
Reported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @mbedmain