Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 SPI: Update and improvement #15028

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Few updates for STM32 SPI:

@LMESTM
@rvasquez6089 @vznncv

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

FPGA tests OK

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 27, 2021
@ciarmcom ciarmcom requested a review from a team August 27, 2021 16:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change includes a move of pullnone to pulldown that is not related to SPI V2 I think, better to split it

targets/TARGET_STM/stm_spi_api.c Show resolved Hide resolved
@0xc0170 0xc0170 changed the title STM32 SPI: Update and improvment STM32 SPI: Update and improvement Aug 30, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 1, 2021

This is waiting for #14981 as it contains the same commits here now, I'll set as preceding PR required

@mergify
Copy link

mergify bot commented Sep 2, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@jeromecoutant
Copy link
Collaborator Author

This is waiting for #14981 as it contains the same commits here now, I'll set as preceding PR required

Rebase done

Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 simple question check, if probably ok so approved :-)

0xc0170
0xc0170 previously approved these changes Sep 6, 2021
@jeromecoutant
Copy link
Collaborator Author

Let's start CI ?

@mergify mergify bot dismissed 0xc0170’s stale review September 7, 2021 12:33

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 8, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 3eae29b into ARMmbed:master Sep 8, 2021
@mergify mergify bot removed the ready for merge label Sep 8, 2021
@jeromecoutant jeromecoutant deleted the PR_SPI_V2 branch September 8, 2021 14:07
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants