Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mbed-os-5.15] Nuvoton M480/M451 CAN API support mask feature #15026

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

This PR is backport of #15020 into Mbed OS 5.15 to enable M480/M451 CAN mask feature for Mbed CAN filter. In this PR, it will also handle standard ID or extended ID frame as while enable H/W mask feature.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team August 26, 2021 12:00
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

targets/TARGET_NUVOTON/TARGET_M451/can_api.c Outdated Show resolved Hide resolved
@mergify mergify bot dismissed 0xc0170’s stale review August 26, 2021 16:40

Pull request has been modified.

@ciarmcom ciarmcom requested a review from a team August 26, 2021 17:00
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2021

Test run: FAILED

Summary: 2 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage-lts
  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2021

Jenkins internal error, CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2021

Test run: FAILED

Summary: 2 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage-lts
  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2021

Both seem to be present and not related to this PR. We will need to fix it in our CI.

cc @ARMmbed/mbed-os-test

@mbed-ci
Copy link

mbed-ci commented Sep 1, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 1, 2021

dynamic memory usage stage should be ignored, it was disabled for 5.15 pipeline.

Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mergify mergify bot added the needs: work label Sep 8, 2021
@0xc0170 0xc0170 merged commit b4040f2 into ARMmbed:mbed-os-5.15 Sep 9, 2021
@mergify mergify bot removed the ready for merge label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants