Fix IAR cmsis update breakage #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue was reported via #15013 (I closed it). |
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
jeromecoutant
approved these changes
Aug 20, 2021
|
I've noticed I got a problem with an email, I'll rebase to fix this |
mbed-cli1 does not pass -I to IAR for iarasm (comparing to other toolchains). Because old tools are frozen, we implement this workaround for fixing the build. We use preprocessor macros that are passed to .S files anyway, so we do not loose anything but we do diverge again from CMSIS, for now..
0xc0170
force-pushed
the
fix-iar-cmsis-update
branch
from
e7ab652
to
19f2138
Compare
|
Rebased, author fixed. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
LDong-Arm
moved this from In progress (8)
to Reviewer approved & awaiting CI & merge (3)
in Mbed Core
Mbed Core
automation
moved this from Reviewer approved & awaiting CI & merge (3)
to Done
Aug 24, 2021
mbedmain
added
release-version: 6.15.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Our old tools do not pass includes to iarasm (it could be due to path length or other limitations there, I could dig into the history and find out but I don't think it's worth for the old tools). I introduce this fix to fix the build and let IAR be still buildable.
I tested with building rtos test for one target.
cc @ARMmbed/team-st-mcd Thanks for reporting this.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers