CYW43XXX Cordio HCI driver: update BT power up sequences to remove redundant delay (500ms) during HCIDrive initialization #14988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@npal-cy, thank you for your changes. |
pan-
reviewed
Aug 10, 2021
| @@ -103,9 +103,6 @@ class HCIDriver : public CordioHCIDriver { | |||
| { | |||
| //Prevent PSoC6 to enter deep-sleep till BT initialization is complete | |||
| sleep_manager_lock_deep_sleep(); | |||
| rtos::ThisThread::sleep_for(500ms); | |||
| bt_power = 1; | |||
There was a problem hiding this comment.
Is it necessary to keep bt_power member variable ? It doesn't seems to be used anymore (except for initialization).
I also noticed that it is initialized differently in the transport (PullNone) from the HCI (PullUp) driver.
There was a problem hiding this comment.
Hi @pan,
I updated code according to your comment. Additionally cleaned some indentations (replaced tab to spaces)
Regards,
Nazar
added 2 commits
August 13, 2021 17:25
…BT_POWER operation during HCIDrive initialization. Current BT_POWER sequence: 1. BT_POWER=0 ( from CyH4TransportDriver::initialize) 2. delay 1ms ( from CyH4TransportDriver::initialize) 3. BT_POWER=1 ( from CyH4TransportDriver::initialize) 4. delay 500ms (from HCIDriver::do_initialize) 5. BT_POWER=1 (from HCIDriver::do_initialize) 6. delay 500ms (from HCIDriver::do_initialize) updates: 1. remove 4) and 5) 2. keep all BT_POWER operations in one place. The best logic place is CyH4TransportDriver::initialize. So finally the BT_POWER sequences should looks like: 1. BT_POWER=0 ( from CyH4TransportDriver::initialize) 2. delay 1ms ( from CyH4TransportDriver::initialize) 3. BT_POWER=1 ( from CyH4TransportDriver::initialize) 4. delay 500ms ( from CyH4TransportDriver::initialize)
…ver class; 2. set PullUp for bt_power in CyH4TransportDriver; 3. cleanup code: replace tabs to 4 spaces
npal-cy
force-pushed
the
pr/swintegration-501
branch
from
ce6313c
to
b245445
Compare
0xc0170
approved these changes
Aug 16, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.14.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update of BT power up sequences to remove redundant delay (500ms) in BT_POWER operation during HCIDrive initialization.
Current BT_POWER sequence:
Suggest to update:
So finally the BT_POWER sequences should looks like:
Depends on: PR#14982
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/team-cypress
CY8CKIT_062_WIFI_BT-ble-cordio-hci.pdf
CY8CKIT_062S2_43012-full-test.pdf
CY8CPROTO_062_4343W-ble-cordio-hci.pdf
CYW9P62S1_43012EVB_01-ble-cordio-hci.pdf
CYW9P62S1_43438EVB_01-ble-cordio-hci.pdf