Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more uarts for STM32F103xG #14976

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

LukasKarel
Copy link
Contributor

Summary of changes

Add possibility to use 5 UARTS with STM32F103xG.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@LukasKarel LukasKarel changed the title add more uarts for STM32F103xG Add more uarts for STM32F103xG Aug 4, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 4, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Aug 4, 2021

@LukasKarel, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Aug 4, 2021
@0xc0170 0xc0170 requested a review from a team August 4, 2021 14:53
@ciarmcom ciarmcom added the stale Stale Pull Request label Aug 5, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Aug 5, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 5, 2021

How did you test all these uarts?

@0xc0170 0xc0170 removed the stale Stale Pull Request label Aug 5, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Aug 5, 2021
@LukasKarel
Copy link
Contributor Author

LukasKarel commented Aug 5, 2021

How did you test all these uarts?

Actually I only tested UART4 because my custom board uses it for logging purposes. I thought this wont need any further changes because I copied this approach from another target and it worked fine for me.

@0xc0170 0xc0170 removed the stale Stale Pull Request label Aug 5, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 5, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2021

CI started

@0xc0170 0xc0170 removed the stale Stale Pull Request label Aug 12, 2021
@mbed-ci
Copy link

mbed-ci commented Aug 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 9bcc486 into ARMmbed:master Aug 13, 2021
@mergify mergify bot removed the ready for merge label Aug 13, 2021
@jeromecoutant
Copy link
Collaborator

Thx @LukasKarel

FYI: if you want to make your custom board public, you can add it in
https://github.com/ARMmbed/stm32customtargets

@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants