Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB connect problem in non blocking mode #14970

Merged

Conversation

MubeenHCLite
Copy link
Contributor

@MubeenHCLite MubeenHCLite commented Jul 30, 2021

connected in non blocking mode (cinnect_blocking = false)

Summary of changes

Added HAL_PCD_Start() in init() so that the USB is detected in non blocking mode (connect_blocking = false)

Impact of changes

Fixes : #14763

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


connected in non blocking mode (cinnect_blocking = false)
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 30, 2021
@ciarmcom ciarmcom requested a review from a team July 30, 2021 05:30
@ciarmcom
Copy link
Member

@MubeenHCLite, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 30, 2021

Wasn't there an issue opened or similar pull request related to connect issue? Or they are unrelated.

@Patater
Copy link
Contributor

Patater commented Jul 30, 2021

Wasn't there an issue opened or similar pull request related to connect issue? Or they are unrelated.

This one? #14763

@MubeenHCLite
Copy link
Contributor Author

Wasn't there an issue opened or similar pull request related to connect issue? Or they are unrelated.

This one? #14763

The PR is for the same issue.

@ABOSTM
Copy link
Contributor

ABOSTM commented Jul 30, 2021

@MubeenHCLite , you need to add
fixes #14763
at the end of your description so that issue will be closed automatically by github when this PR will be merged.

Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 2, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 7214fe9 into ARMmbed:master Aug 2, 2021
@mergify mergify bot removed the ready for merge label Aug 2, 2021
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USBSerial doesn't work with connect_blocking = false on STM32F401
7 participants