Update references to time values to use chrono #14941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticker test contains definition of variable total_ticks, which is unused in the file since removal of function wait_and_print() in commit aaa15bc
ciarmcom
added
the
release-type: patch
adbridge
previously requested changes
Jul 23, 2021
|
|
||
| TEST_ASSERT_UINT32_WITHIN(TOLERANCE_US, MULTI_TICKER_TIME_MS * 1000, time_diff); | ||
| TEST_ASSERT_DURATION_WITHIN(TOLERANCE, MULTI_TICKER_TIME, time_diff); |
There was a problem hiding this comment.
Could you clarify this comment? As TOLERANCE here is not a function like macro as TOLERANCE_US is above , it's just a constant value of 1000us.
hazzlim
force-pushed
the
update-tests-to-use-chrono
branch
from
0a701cc
to
d772834
Compare
rwalton-arm
previously requested changes
Jul 29, 2021
References to time should do so using std::chrono. We reworked tests in
connectivity and drivers to use std::chrono and new APIs in order to
remove deprecation warnings resulting from deprecated API calls.
This required addition of a macro for test assertions using std::chrono
values.
As host test "timing_drift_auto" expects time values represented as an
integral number of microseconds, we explicitly provide this in place
using "microseconds{TICKER_TIME}.count()" in the relevant ticker tests.
We recognise this is ugly, but thought it best to descriptively convert
from std::chrono to the host test's required representation.
Co-authored-by: Hari Limaye <[email protected]>
hazzlim
force-pushed
the
update-tests-to-use-chrono
branch
from
d772834
to
86c2d70
Compare
mergify
bot
dismissed
rwalton-arm’s stale review
Pull request has been modified.
|
@rwalton-arm thank you for your review, I have addressed all comments and rebased |
Thanks. All looks good to me! |
Mbed Core
automation
moved this from Review in progress (4)
to Reviewer approved & awaiting CI & merge (3)
Jul 29, 2021
rwalton-arm
approved these changes
Jul 29, 2021
0xc0170
approved these changes
Jul 29, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Mbed Core
automation
moved this from Reviewer approved & awaiting CI & merge (3)
to Done
Jul 30, 2021
mbedmain
added
release-version: 6.14.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reworked connectivity and drivers greentea tests to replace deprecated API calls with new APIs that accept std::chrono values, and updated references to time values in these tests to use std::chrono values.
This PR is picking up from #14453.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Verified that tests touched by this PR build with CLI 1 and CLI 2, and run with success in all cases on target board K66F. In particular, ticker tests now pass which were previously failing in CI following #14453.
Reviewers
@adbridge @kjbracey-arm @ARMmbed/mbed-os-core