python: Allow newer prettytable with newer python #14940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
previously approved these changes
Jul 21, 2021
|
CI started |
LDong-Arm
reviewed
Jul 21, 2021
requirements.txt
Outdated
| @@ -1,6 +1,7 @@ | |||
| colorama==0.3.9 | |||
| urllib3[secure]>=1.26.5 | |||
| prettytable==0.7.2 | |||
| PrettyTable<=1.0.1; python_version < '3.6' | |||
There was a problem hiding this comment.
Do we need to handle version < 3.6? From b8388cd:
A few libraries we depend on no longer support old versions of Python
like 3.5 and 3.6. Remove testing for these old versions.
There was a problem hiding this comment.
We haven't removed python 2 support, yet, so this covers there. Old python 3 doesn't necessarily need supporting, but there is no need to block it by requiring a prettytable version that has dropped support for that older python version.
LDong-Arm
previously approved these changes
Jul 21, 2021
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI seems to be failing on Mbed CLI 1 not being able to parse requirements.txt https://github.com/ARMmbed/mbed-cli/blob/master/mbed/mbed.py#L1024 |
Mbed CLI 1 parses the base requirements.txt and attempts to
automatically install missing python libraries for you. Unfortunately,
it's requirements parser is not as capable as the one shipping with pip.
In particular, we are unable to express different version of libraries
conditional on the version of Python being used.
---
[mbed] ERROR: Unknown Error: Unsupported environment marker: python_version < '3.6'
Remove the direct dependency on prettytable from requirements.txt, as
mbed-os-tools depends on prettytable and we can pick up the dependency
(as properly expressed conditionally on the Python version) from there,
without having to use the limited requirements parser in Mbed CLI 1.
This helps to allow installation of Mbed OS's Python requirements, when CMake is used, into the same Python environment as mbed-os-tools. The versions specified here are aligned with mbed-os-tools; tools/cmake/requirements.txt depends on the same version of prettytable as mbed-os-tools's requirements.txt.
Patater
force-pushed
the
update-prettytable
branch
from
cacc434
to
14d4ee3
Compare
|
Updated to dodge the limitations of the Mbed CLI 1 requirements parser. |
mergify
bot
dismissed stale reviews from 0xc0170 and LDong-Arm
Pull request has been modified.
|
CI started |
ciarmcom
added
the
release-type: patch
|
@Patater, thank you for your changes. |
0xc0170
approved these changes
Jul 21, 2021
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This helps to allow installation of Mbed OS requirements into the same
Python environment as mbed-os-tools or mbed-os.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers