Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove host_tests from mbed-os/tools #14932

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Remove host_tests from mbed-os/tools #14932

merged 1 commit into from
Jul 21, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jul 19, 2021 •
edited
Loading

Summary of changes

fixes ARMmbed/greentea#315
mbed-host-tests (mbedhtrun) is maintained as part of mbed-os-tools but there is a redundant duplicate of host_tests under mbed-os/tools/ directory this PR changes to remove those duplicates and update test_api py modules to use host tests from mbe-host-tests.

Impact of changes

None.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

This was referenced Jul 19, 2021
Closed
Closed
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 19, 2021
@ciarmcom ciarmcom requested a review from a team July 19, 2021 12:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

rwalton-arm
rwalton-arm previously requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@rwalton-arm rwalton-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message there's a typo: "mbe-host-tests". Everything else looks good to me.

@rajkan01
Remove host_tests from mbed-os/tools
e75b67f 
host tests (mbedhtrun) is maintained as part of mbed-os-tools but there
is a redundant duplicate of host_tests under mbed-os/tools/ directory
this PR changes to remove those duplicates and update test_api py modules
to use host tests from mbed-host-tests
@mergify mergify bot dismissed rwalton-arm’s stale review July 20, 2021 12:08

Pull request has been modified.

@rajkan01
Copy link
Contributor Author

In the commit message there's a typo: "mbe-host-tests". Everything else looks good to me.

@rwalton-arm I made a correction in the commit message, please re-review

@mergify mergify bot added needs: CI and removed needs: work labels Jul 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 21, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 530c90b into master Jul 21, 2021
@mergify mergify bot removed the ready for merge label Jul 21, 2021
@0xc0170 0xc0170 deleted the remove_tools_host_tests branch July 21, 2021 13:24
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalton-arm rwalton-arm rwalton-arm approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: tools release-version: 6.14.0
Projects
None yet
Milestone
No milestone
6 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @rwalton-arm @mbedmain