Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cellular unittest CMake #14924

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Refactor cellular unittest CMake #14924

merged 3 commits into from
Jul 20, 2021

Conversation

rajkan01
Copy link
Contributor

Summary of changes

Fixes #14877

  • Update cellular AT, common, device unit tests CMake depends on a mock, which is required for the test instead of depending on the group of mbed-stubs, mbed-headers, mbed_stub_headers, libraries.
  • Limit the cellular context unit test CMake target_sources to keep only required sources

Impact of changes

None.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@rajkan01
CMake: Limit at cellular unittest to use mock what it depends
6cf1211 
Update AT cellular unit tests CMake depends on a mock, which is required
for the test instead of depending on the group of mbed-stubs,
mbed-headers, mbed_stub_headers, libraries.
@rajkan01
CMake: Limit cellular common unit tests to use mocks what it depends
27bfa90 
Update cellular common unit tests CMake depends on a mock, which is
required for the test instead of depending on the group of
mbed-headers libraries.
@rajkan01
CMake: Limit cellular device cmake to use mocks/sources what it depends
f32a3cb 
Update cellular device unit tests CMake depends on a mock, which is
required for the test instead of depending on the group of mbed-stubs,
mbed-headers, mbed_stub_headers, libraries.
Limit the cellular context unit test CMake target_sources to keep only
required sources
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 15, 2021
@ciarmcom ciarmcom requested a review from a team July 15, 2021 14:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 15, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 16, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@0xc0170 0xc0170 merged commit 2181d7c into master Jul 20, 2021
@0xc0170 0xc0170 deleted the refactor_cellular_unittest branch July 20, 2021 08:10
@mergify mergify bot removed the ready for merge label Jul 20, 2021
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
component: connectivity release-version: 6.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor connectivity cellular unit test to use mocks lib what it depends
6 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @mbedmain