Refactor connectivity netsocket unittests #14920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
LDong-Arm
previously approved these changes
Jul 14, 2021
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
0xc0170
previously approved these changes
Jul 16, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
rwalton-arm
previously requested changes
Jul 16, 2021
connectivity/netsocket/tests/UNITTESTS/netsocket/DTLSSocket/CMakeLists.txt
Show resolved
Hide resolved
hazzlim
force-pushed
the
refactor-connectivity-netsocket-unittests
branch
from
28cf6cb
to
837045c
Compare
mergify
bot
dismissed stale reviews from LDong-Arm, 0xc0170, and rwalton-arm
Pull request has been modified.
rwalton-arm
previously approved these changes
Jul 19, 2021
Some source files included when building netsocket unit tests with CMake were determined to be unused by removing the files from target_sources() and verifying that the tests still built and ran successfully. These files have been removed from CMake builds.
Some netsocket unit tests depend on nanostack-libservice library, but should use stubs instead of including the source files. We remove the source files and link to mbed-stubs-nanostack-libservice.
The CMake target `mbed-headers` brings in all headers, and we are gradually moving away from it and explicitly use only headers needed by each unit test.
hazzlim
force-pushed
the
refactor-connectivity-netsocket-unittests
branch
from
837045c
to
14cab32
Compare
mergify
bot
dismissed
rwalton-arm’s stale review
Pull request has been modified.
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jul 20, 2021
mbedmain
added
release-version: 6.14.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Clean up CMake definitions of connectivity-netsocket unit tests to only include required source files, and to depend only on headers each test uses.
Fixes #14879
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers
@rajkan01 @ARMmbed/mbed-os-core