Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

802.15.4 stm-s2lp-rf-driver update to v1.0.10 #14913

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Jul 12, 2021

Summary of changes ¨

Update stm-s2lp-rf-driver to v1.0.10.

The GPIO/IRQ error catching feature was enabled in #14843 and it generated hard fault when initialising stm-s2lp-rf-driver. In this version only the configured GPIO pin is initialised, leaving other possible GPIO pins uninitialized.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter , @JarkkoPaso , @juhhei01 , @mikaleppanen


Arto Kinnunen added 2 commits July 12, 2021 16:40
…es from f491d77de8..7d12478914

7d12478914 Initialise only configured GPIO pin (ARMmbed#77)

git-subtree-dir: connectivity/drivers/802.15.4_RF/stm-s2lp-rf-driver
git-subtree-split: 7d124789144549a5670b6e67866c1c9f2158beab
…river_fix

* commit '8a76989b8c269fc68dda3df16315e390ab6a58e4':
  Squashed 'connectivity/drivers/802.15.4_RF/stm-s2lp-rf-driver/' changes from f491d77de8..7d12478914
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 12, 2021
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@juhhei01 @JarkkoPaso @mikaleppanen @mikter @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So only one pin can be enabled and active at the time

@artokin
Copy link
Contributor Author

artokin commented Jul 12, 2021

@0xc0170 , that is right.
The code is using one of the four possible GPIO pins. The pin is configured by using define INT_IN_GPIO:
https://github.com/ARMmbed/mbed-os/blob/master/connectivity/drivers/802.15.4_RF/stm-s2lp-rf-driver/source/NanostackRfPhys2lp.cpp#L54
Previously all the GPIO pins were initialised but now only the used pin will be initialised.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 12, 2021
@mbed-ci
Copy link

mbed-ci commented Jul 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 43fe6d9 into ARMmbed:master Jul 13, 2021
@mergify mergify bot removed the ready for merge label Jul 13, 2021
@artokin artokin deleted the update_stm_s2lp_rf_driver branch July 13, 2021 08:49
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants