Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32 : README updates about custom boards #14905

Merged
merged 2 commits into from
Jul 13, 2021
Merged

STM32 : README updates about custom boards #14905

merged 2 commits into from
Jul 13, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Introduction of https://github.com/ARMmbed/stm32customtargets

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Patater
Patater previously requested changes Jul 9, 2021
View reviewed changes
targets/TARGET_STM/README.md Outdated
@@ -321,6 +334,13 @@ $ mv TARGET_STM32H745ZIT TARGET_H745ZI_BOARD
```


### Make you custom board public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- Make you custom board public
+ Make your custom board public

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thx

targets/TARGET_STM/README.md Outdated
@@ -19,16 +18,19 @@ Table of Contents
* [Add a custom board](#add-a-custom-board)
* [Board specific files (pinmap)](#board-specific-files-pinmap)
* [Use of custom_targets.json](#use-of-custom_targetsjson)
* [Make you custom board public](#make-you-custom-board-public)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- [Make you custom board public](#make-you-custom-board-public)
+ [Make your custom board public](#make-your-custom-board-public)

@mergify mergify bot added the needs: work label Jul 9, 2021
@mergify mergify bot dismissed Patater’s stale review July 9, 2021 14:35

Pull request has been modified.

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 9, 2021
@ciarmcom ciarmcom requested a review from a team July 9, 2021 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 9, 2021

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Patater
Patater previously requested changes Jul 9, 2021
View reviewed changes
targets/TARGET_STM/TARGET_STM32WL/README.md Outdated
MBED_WEAK void set_antenna_switch(RBI_Switch_TypeDef state)
```

So yo can overwrite it for your custom board.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- yo
+ you

targets/TARGET_STM/README.md Outdated
@@ -321,6 +334,13 @@ $ mv TARGET_STM32H745ZIT TARGET_H745ZI_BOARD
```


### Make your custom board public

We will be happy to add every public boards in https://github.com/ARMmbed/stm32customtargets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- every public boards
+ every public board

@mergify mergify bot dismissed Patater’s stale review July 13, 2021 10:09

Pull request has been modified.

Patater
Patater previously requested changes Jul 13, 2021
View reviewed changes
targets/TARGET_STM/README.md Outdated
* [ST specific implementation](#st-specific-implementation)
* [Pin configuration](#pin-configuration)
* [Alternate feature](#alternate-feature)
* [Conflict pins](#conflict-pins)
* [Clock selection](#clock-selection)
* [System clock](#system-clock)
* [Low power clock](#low-power-clock)
* [I2C TIming calculation algorothm](#i2c-timing-calculation-algorothm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- TIming
+ Timing

@mergify mergify bot dismissed Patater’s stale review July 13, 2021 10:23

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2021

CI started

@0xc0170 0xc0170 merged commit f37b0c4 into ARMmbed:master Jul 13, 2021
@mergify mergify bot removed the ready for merge label Jul 13, 2021
@jeromecoutant jeromecoutant deleted the PR_STM32CUSTOM branch July 15, 2021 09:12
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeromecoutant @ciarmcom @0xc0170 @Patater @mbedmain