Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move connectivity nanostack libservice stub #14896

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Move connectivity nanostack libservice stub #14896

merged 3 commits into from
Jul 13, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jul 8, 2021 •
edited
Loading

Summary of changes

fixes #14857
Preceding PR #14890

  • Moved the connectivity nanostack-libservice stubs into the connectivity/libraries directory where the nanostack libservice component present as nanostack libservice source copied from the external repo.
  • Previously all nanostack libservice headers part of mbed-headers-connectivity. This PR moves all the nanostack libservice headers into newly added mbed-headers-nanostack-libraries. This makes the nanostack libservice stubs more self-contained and
    improves the composition of the library.
  • Limit the mbed-stubs-nanostack-libservice to required dependen…

Impact of changes

None.

Migration actions required

None

Documentation

To be updated

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 8, 2021
@ciarmcom ciarmcom requested a review from a team July 8, 2021 13:30
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2021

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@rajkan01 rajkan01 force-pushed the move_connectivity_nanostack_libservice_stub branch from 8e76f8c to a2345bb Compare July 8, 2021 13:51
@mergify
Copy link

mergify bot commented Jul 9, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@rajkan01 rajkan01 force-pushed the move_connectivity_nanostack_libservice_stub branch 3 times, most recently from 9b3a6b5 to 7834760 Compare July 9, 2021 09:55
@rajkan01 rajkan01 mentioned this pull request Jul 12, 2021
Merged
@mergify
Copy link

mergify bot commented Jul 12, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@rajkan01 rajkan01 force-pushed the move_connectivity_nanostack_libservice_stub branch from 7834760 to 6477789 Compare July 12, 2021 12:18
LDong-Arm
LDong-Arm previously approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Guess there'll be another PR to only link used headers in mbedtls and nanostack once this is merged.

@mergify mergify bot added needs: CI and removed needs: work labels Jul 12, 2021
@rajkan01 rajkan01 force-pushed the move_connectivity_nanostack_libservice_stub branch from 6477789 to 4a7d514 Compare July 13, 2021 07:29
@mergify mergify bot dismissed LDong-Arm’s stale review July 13, 2021 07:30

Pull request has been modified.

@mergify mergify bot added needs: work and removed needs: CI labels Jul 13, 2021
@mbed-ci
Copy link

mbed-ci commented Jul 13, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@rajkan01 rajkan01 force-pushed the move_connectivity_nanostack_libservice_stub branch from 4a7d514 to e0e953d Compare July 13, 2021 08:45
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@rajkan01 rajkan01 requested a review from LDong-Arm July 13, 2021 09:38
LDong-Arm
LDong-Arm previously approved these changes Jul 13, 2021
View reviewed changes
@mergify
Copy link

mergify bot commented Jul 13, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@rajkan01
CMake: Move nanostack libservice stubs to the connectivity/libraries dir
d95bf96 
Move the connectivity nanostack-libservice stubs into the connectivity/libraries
directory where the nanostack libservice component present as nanostack
libservice source copied from the external repo. So we can avoid duplicating
the mbed-os source tree in a central UNITTESTS folder.
@rajkan01
CMake: Add mbed-headers-nanostack-libservice library
22b2e9f 
Previously all nanostack libservice headers part of
mbed-headers-connectivity. This PR moves all the nanostack
libservice headers into newly added mbed-headers-nanostack-libraries.
This makes the nanostack libservice stubs more self-contained and
improves the composition of the library.
@rajkan01
CMake: Limit the mbed-stubs-nanostack-libservice to required dependen…
d488597 
…cy mocks
@rajkan01 rajkan01 force-pushed the move_connectivity_nanostack_libservice_stub branch from e0e953d to d488597 Compare July 13, 2021 12:52
@mergify mergify bot dismissed LDong-Arm’s stale review July 13, 2021 12:53

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 9a59145 into master Jul 13, 2021
@mergify mergify bot removed the ready for merge label Jul 13, 2021
@0xc0170 0xc0170 deleted the move_connectivity_nanostack_libservice_stub branch July 13, 2021 14:20
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@pan- pan- Awaiting requested review from pan-

@paul-szczepanek-arm paul-szczepanek-arm Awaiting requested review from paul-szczepanek-arm

Assignees
No one assigned
Labels
component: connectivity component: security component: test release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move remaining stubs files from UNITTESTS/stubs/connectivity to the Connectivity/**
7 participants
@rajkan01 @ciarmcom @mbed-ci @0xc0170 @paul-szczepanek-arm @LDong-Arm @mbedmain