Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC: STM32H7: Skip Negative input analog channels (INN) #14895

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

AnishKumarHCL
Copy link
Contributor

Summary of changes

mbed-os does not support ADC INN channels. So removed INN channels from
STM32H7 PeripheralPins.c files and updated STM32_gen_PeripheralPins.py
script to skip INN adc channels.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 8, 2021
@ciarmcom ciarmcom requested review from jeromecoutant and a team July 8, 2021 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2021

@AnishKumarHCL, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request about python script:

  • could you update GENPINMAP_VERSION = "1.20.1" to 1.20.2 ?
  • why did you change chmod ?

@AnishKumarHCL AnishKumarHCL requested review from jeromecoutant and removed request for a team July 9, 2021 15:46
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: @pennam

@mergify mergify bot added needs: CI and removed needs: review labels Jul 12, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 12, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit abd32c7 into ARMmbed:master Jul 13, 2021
@mergify mergify bot removed the ready for merge label Jul 13, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants