Add CTest support for mbed-drivers-ticker greentea test
#14892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@rwalton-arm, thank you for your changes. |
|
Ready for review now. |
rwalton-arm
force-pushed
the
greentea_ctest
branch
from
93e3498
to
e17ead1
Compare
rwalton-arm
force-pushed
the
greentea_ctest
branch
from
e17ead1
to
792f2e3
Compare
LDong-Arm
suggested changes
Jul 9, 2021
There was a problem hiding this comment.
@rwalton-arm Thanks, this looks and works really well! I just added some comments.
LDong-Arm
reviewed
Jul 12, 2021
LDong-Arm
previously requested changes
Jul 12, 2021
LDong-Arm
reviewed
Jul 12, 2021
LDong-Arm
reviewed
Jul 12, 2021
rwalton-arm
force-pushed
the
greentea_ctest
branch
from
792f2e3
to
442b1bc
Compare
LDong-Arm
reviewed
Jul 12, 2021
rwalton-arm
force-pushed
the
greentea_ctest
branch
2 times, most recently
from
8501ef1
to
9686d1d
Compare
LDong-Arm
reviewed
Jul 13, 2021
LDong-Arm
previously approved these changes
Jul 13, 2021
0xc0170
previously approved these changes
Jul 14, 2021
We weren't setting the "supported_application_profiles" correctly for some baremetal supported targets. This didn't cause build failures with mbed-cli 1 as it just seems to ignore this config parameter. In our CMake build system we have added a hard dependency on the supported_application_profiles; we fail the build if the profile we're trying to build isn't in the list.
The github workflow to test building multiple executables was using the soon to be deprecated docker image "mbedos/mbed-os-env:latest". This commit points it at the new docker image on ghcr.io.
rwalton-arm
force-pushed
the
greentea_ctest
branch
from
14042b2
to
1a7a89a
Compare
Patater
approved these changes
Aug 11, 2021
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Don't panic. This was the aborted run. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 11, 2021
Following approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 11, 2021
Following approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 11, 2021
Following approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 12, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/equeue requires MBED_EXTENDED_TESTS. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 13, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 13, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 13, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 13, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 20, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Aug 20, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
mbedmain
removed
release-type: patch
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Sep 18, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Sep 27, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
hazzlim
added a commit
to hazzlim/mbed-os
that referenced
this pull request
Oct 2, 2021
Following the approach defined in ARMmbed#14892 and ARMmbed#14902, events greentea tests are ported to enable running with CTest. events/queue and events/timing both require DEVICE_USTICKER.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds CTest support for greentea tests, and enables it for the
mbed-drivers-tickertest.This PR makes the following changes:
BUILD_GREENTEA_TESTSoption to enable greentea testsmbed-drivers-tickertest, usingmbedhtrunto run the testMBED_HTRUN_ARGUMENTScache variable which is a list of options to forward tombedhtrunChecks have been added in
mbed_greentea.cmaketo keep the old flow working.These checks should be removed once all tests are reworked.
Fixes #14852
Impact of changes
Migration actions required
Documentation
#14854
Pull request type
Test results
Reviewers