Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity tests: early skip fix #14767

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

ghseb
Copy link

@ghseb ghseb commented Jun 14, 2021

Summary of changes

Adding mbed-os subdirectories that are not required for a specific project to .mbedignore is a good way to reduce compilation time. Sometimes it happens that tests depend on ignored files, which causes the test-build to fail even though the corresponding feature/component is not configured. The reason is that the conditional that skips the test is placed after the includes.

Impact of changes

None

Migration actions required

None

Documentation

Not required I guess.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 14, 2021
@ciarmcom
Copy link
Member

@ghseb, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Patater
Patater previously approved these changes Jun 14, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Jun 14, 2021
@Patater
Copy link
Contributor

Patater commented Jun 14, 2021

Could you put the PR description into your commit message please?

This block of text would be great in the commit message, rather than just in the PR.

Adding mbed-os subdirectories that are not required for a specific project to .mbedignore is a good way to reduce compilation time. Sometimes it happens that tests depend on ignored files, which causes the test-build to fail even though the corresponding feature/component is not configured. The reason is that the conditional that skips the test is placed after the includes.

0xc0170
0xc0170 previously approved these changes Jun 14, 2021
Adding mbed-os subdirectories that are not required for a specific project to .mbedignore is a good way to reduce compilation time. Sometimes it happens that tests depend on ignored files, which causes the test-build to fail even though the corresponding feature/component
is not configured. The reason is that the conditional that skips the test is placed after the includes.
@mergify mergify bot dismissed stale reviews from Patater and 0xc0170 June 14, 2021 08:47

Pull request has been modified.

@ghseb
Copy link
Author

ghseb commented Jun 14, 2021

Could you put the PR description into your commit message please?

This block of text would be great in the commit message, rather than just in the PR.

Adding mbed-os subdirectories that are not required for a specific project to .mbedignore is a good way to reduce compilation time. Sometimes it happens that tests depend on ignored files, which causes the test-build to fail even though the corresponding feature/component is not configured. The reason is that the conditional that skips the test is placed after the includes.

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 changed the title Early test skip connectivity tests: early skip fix Jun 14, 2021
@0xc0170 0xc0170 merged commit 2dcd6c0 into ARMmbed:master Jun 14, 2021
@mergify mergify bot removed the ready for merge label Jun 14, 2021
@ghseb ghseb deleted the early-test-skip branch June 14, 2021 10:28
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants