Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: fix advertising set termination event #14747

Merged
merged 7 commits into from
Jun 17, 2021
Merged

BLE: fix advertising set termination event #14747

merged 7 commits into from
Jun 17, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jun 8, 2021 •
edited
Loading

Summary of changes

This fixes the wrong handle and status being reported in the advertising stop event. To make the event consistent (and correct) a workaround at CORDIO level is needed.

Now the terminate event has a correctly translated status with the connected field set based on whether the event has a valid connection id. The connection id is now translated from HCI id. Added documentation to clarify the behaviour.

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 8, 2021
@ciarmcom ciarmcom requested a review from a team June 8, 2021 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2021

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2021

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

If you add WIP: as a prefix to the headline, it will append do not merge label automatically. I'll do it manually now

@0xc0170 0xc0170 changed the title BLE: fix advertising set termination event (WIP) WIP: BLE: fix advertising set termination event Jun 9, 2021
@paul-szczepanek-arm
Copy link
Member Author

The neatness of the commits belies the violent history of this PR.

@paul-szczepanek-arm paul-szczepanek-arm changed the title WIP: BLE: fix advertising set termination event BLE: fix advertising set termination event Jun 9, 2021
@paul-szczepanek-arm
Copy link
Member Author

@chrisswinchatt-arm , since you're doing a rebase, this PR includes a new cordio fix - you'll have to include that when it's merged.

@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Jun 9, 2021
Merged
@paul-szczepanek-arm
Copy link
Member Author

note to self: merge ARMmbed/mbed-os-example-ble#380 after this is merged

@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Jun 10, 2021
Closed
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 14, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @pan-, @chrisswinchatt-arm, @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Jun 14, 2021 •
edited
Loading

Come on guys, please review.

@ciarmcom ciarmcom removed the stale Stale Pull Request label Jun 14, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Jun 15, 2021
@mbed-ci
Copy link

mbed-ci commented Jun 15, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 17, 2021

Approved to be in the release candidate we are about to produce soon.

@0xc0170 0xc0170 merged commit 8cb8e49 into ARMmbed:master Jun 17, 2021
@mergify mergify bot removed the ready for merge label Jun 17, 2021
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@chrisswinchatt-arm chrisswinchatt-arm chrisswinchatt-arm approved these changes

@pan- pan- Awaiting requested review from pan-

Assignees
No one assigned
Labels
component: connectivity release-version: 6.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paul-szczepanek-arm @ciarmcom @0xc0170 @mbed-ci @chrisswinchatt-arm @mbedmain